[Request]: Run flutter analyze workflow in proper scopes and enforce its results
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
Research direction
Start by locating the CI workflow that runs flutter analyze for all plugins and inspect how changed scopes are determined. Compare the workflow behavior for a plugin-only change, then verify that analysis is limited to affected packages and that analyzer warnings cause the relevant CI check to fail.
Written by the indexing model from the issue text.
Description
Plugin
All
Use case
It makes no sense to run analyze on all packages in every PR.
Here is an example where in PR with device_info_plus files changes only I see warnings for another plugin, because the analyze task runs for all plugins:
Proposal
Suggest to do multiple changes:
- Run
analyzeonly in the scope of changed files in PRs. - Make analyzer warnings failing the set of CI checks to enforce issues resolutions, instead of catching up with fixes later as we do now.
- Dominant language
- Dart
- Stars
- 1.9k
- Forks
- 1.3k
- Avg merge
- 6d 16h
- Merged PRs (30d)
- 16
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fluttercommunity/plus_plugins
-
bug triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
fluttercommunity/plus_plugins#3994 ·
Maintainers usually reply within 1 day
-
[package_info_plus]: Use Flutter's compile-time build name/number on web instead of version.jsonOpen
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
fluttercommunity/plus_plugins#3989 ·
Maintainers usually reply within 1 day
-
enhancement triage
Difficulty 4/5 3-5 days Newbie friendliness 55/100
fluttercommunity/plus_plugins#3976 · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
fluttercommunity/plus_plugins#3974 · 1 reaction ·
Maintainers usually reply within 1 day
-
enhancement triage
Difficulty 5/5 Over a week Newbie friendliness 48/100
fluttercommunity/plus_plugins#3973 ·
Maintainers usually reply within 1 day
All issues in fluttercommunity/plus_plugins
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Nutrition editor unit dropdown ignores selected value, applies wrong unit (silent data corruption)Opennutrition facts
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
openfoodfacts/smooth-app#7812 · 3 comments ·
Maintainers usually reply within 1 day
-
P1
Difficulty 1/5 Under an hour Newbie friendliness 90/100
dart-lang/native#3722 · 1 comment · 1 reaction · 1 assignee ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
Maintainers usually reply within 3 days