onBack stream not closed
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 70/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- dart, flutter
- Domain
- mobile-dev
Research direction
Open lib/base.dart and inspect the dispose method, then trace the _onBack stream controller created there. Confirm whether disposal should close that controller, and verify that the onBack stream is closed when the plugin is disposed.
Written by the indexing model from the issue text.
Description
System info
Issue occurs on: both
Plugin version: 0.3.11
Flutter doctor output:
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, v1.12.13+hotfix.9, on Microsoft Windows [Version 10.0.18363.900], locale en-NZ)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
[√] Android Studio (version 4.0)
[√] VS Code, 64-bit edition (version 1.46.0)
[√] Connected device (1 available)
• No issues found!
Steps to Reproduce
- Navigate to the file base.dart in the plugin lib.
- scroll down to dispose method.
as you can see also in the image, the _onBack stream controller is created but never closed in the dispose. Not sure if this was on purpose or not.
- Dominant language
- Java
- Stars
- 1.5k
- Forks
- 936
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fluttercommunity/flutter_webview_plugin
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
fluttercommunity/flutter_webview_plugin#974 · 3 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 32/100
fluttercommunity/flutter_webview_plugin#973 · 3 comments · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
fluttercommunity/flutter_webview_plugin#972 · 4 reactions ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
fluttercommunity/flutter_webview_plugin#971 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 15/100
fluttercommunity/flutter_webview_plugin#970 · 1 reaction ·
All issues in fluttercommunity/flutter_webview_plugin
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
lugassawan/swe-workbench#799 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Vakore/ZappierGames#89 ·
-
1.20.1-FORGE Module-Enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
MehVahdJukaar/WoodGood#1340 · 1 comment ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
PssbleTrngle/dye_depot#123 ·
-
bug question
Difficulty 2/5 1-3 hours Newbie friendliness 67/100