The populate cap multiplies with locales on locale=all and fallback reads

Open
#3,284 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
56/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp
Domain
backend

Research direction

Read QueryScope.cs:105-113 and LocaleFallbackReader.cs:160-184 to trace how each engine call gets its populate count and how locale and fallback reads run. Then inspect the request path that creates these scopes and the existing populate limit tests. Done means a locale=all read with populate stays within MaxPopulatedEntries across all locale and fallback reads.

Written by the indexing model from the issue text.

Description

area:content performance type:bug

Problem

Each engine call gets a fresh QueryScope and populate count (QueryScope.cs:105-113). LocaleFallbackReader.ReadAllAsync runs one query per locale and ApplyAsync one per fallback locale (LocaleFallbackReader.cs:160-184), so a request with ten locales can populate about ten times MaxPopulatedEntries.

Proposal

Share one populate budget across the locale and fallback reads of a request.

Acceptance

  • A locale=all read with populate stays within MaxPopulatedEntries in total

Found in the code review of 17 Nov 2026 (P5).

Dominant language
C#
Stars
569
Forks
107
Avg merge
2h 49m
Merged PRs (30d)
397

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fluentcms/FluentCMS

All issues in fluentcms/FluentCMS

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.