Submenu hidden/disable not identical to Item
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- react, typescript
- Domain
- frontend
Research direction
Start by comparing the disable-hide-submenu documentation with src/components/Submenu.tsx lines 66-69 and the reported Item behavior. Determine whether Submenu should expose data through handlerParams or whether the documentation should state that it is unsupported; done means the implementation and documentation agree.
Written by the indexing model from the issue text.
Description
Do you want to request a feature or report a bug?
Bug either Docs or Submenu component.
What is the current behavior?
handlerParams in Submenu doesn't include data property, which isn't even defined for Submenu.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your CodeSandbox (https://codesandbox.io/s/new) example below:
https://fkhadra.github.io/react-contexify/disable-hide-submenu says it's the same as Item, but it's not.
https://github.com/fkhadra/react-contexify/blob/42e7d2061306e9d9744c1dddc5cae748a9772fce/src/components/Submenu.tsx#L66-L69
What is the expected behavior?
That I can provide data property to Submenu and it will be provided with the handlerParams to the BooleanPredicate just like Item.
OR
Clear documentation that this isn't supported for Submeny
Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
Version 5 of react-contexify
- Dominant language
- TypeScript
- Stars
- 1.2k
- Forks
- 133
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fkhadra/react-contexify
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
fkhadra/react-contexify#275 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
fkhadra/react-contexify#269 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
fkhadra/react-contexify#268 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
fkhadra/react-contexify#265 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
fkhadra/react-contexify#264 · 1 comment ·
All issues in fkhadra/react-contexify
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
cline/mcp-marketplace#2932 ·
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 82/100
lingdojo/kana-dojo#32188 · 1 comment · 5 reactions ·
Maintainers usually reply within 1 day
-
triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Portkey-AI/gateway#1844 ·
Maintainers usually reply within 1 day
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 61/100
rjsf-team/react-jsonschema-form#5495 ·
Maintainers usually reply within 2 days