[FR] Update cmake/external/uWebSockets to version more recent than 2017
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 30/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cmake, cpp
- Domain
- build-system
Research direction
Start with cmake/external/uWebSockets.cmake and compare the pinned 4d94401b dependency with the referenced uWebSockets releases. Then inspect scripts/git/patches/uWebSockets/0001-fix-want-write-and-sprintf-deprecation.patch and the referenced HTTPSocket.h and Socket.h changes. Done means selecting a supported newer version and updating the dependency integration and patching for the resulting API changes.
Written by the indexing model from the issue text.
Description
Feature proposal
- Firebase Component: build (cmake/external/uWebSockets)
This SDK uses cmake/external/uWebSockets 4d94401b from 20170925 ~v0.14.4... which is VERY old!
https://github.com/firebase/firebase-cpp-sdk/blob/b4f9e0b45d9cf69688cdb0285627aedfcc906dd9/cmake/external/uWebSockets.cmake#L21
https://github.com/uNetworking/uWebSockets/tree/4d94401b9c98346f9afd838556fdc7dce30561eb
According to https://github.com/uNetworking/uWebSockets/releases?page=16, a 20170925 commit would place this code between releases v0.14.4 and v0.14.5.
The latest uWebSockets is v20.63.0.
The version is not as big of a jump as it may seem.
According to https://github.com/uNetworking/uWebSockets/releases?page=11, release 0.17.6 was followed by 18.0.0, so I think they just dropped the leading "zero dot".
That said, there do appear to be some fairly significant changes since v0.14.4.
Most importantly, this SDK patches src/HTTPSocket.h and src/Socket.h that no longer exists in the newer uWebSockets code.
https://github.com/firebase/firebase-cpp-sdk/blob/b4f9e0b45d9cf69688cdb0285627aedfcc906dd9/scripts/git/patches/uWebSockets/0001-fix-want-write-and-sprintf-deprecation.patch
It looks like src/HTTPSocket.h was refactored out on 20190902, and src/Socket.h on 20190910.
I am sure that it would be non-trivial to update to the latest uWebSockets, but it may be worth updating to at least a version closer to the refactor, but preferably to the latest.
Most of the other cmake/external dependencies seem more reasonably up to date, but it would be nice to update them to as recent as possible.
- Dominant language
- C++
- Stars
- 326
- Forks
- 138
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 3
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from firebase/firebase-cpp-sdk
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
firebase/firebase-cpp-sdk#1905 · 2 comments ·
-
api: firestore
Difficulty 5/5 Over a week Newbie friendliness 35/100
firebase/firebase-cpp-sdk#1920 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 70/100
firebase/firebase-cpp-sdk#1904 · 1 comment ·
-
new type: question
Difficulty 4/5 3-5 days Newbie friendliness 45/100
firebase/firebase-cpp-sdk#1892 · 1 comment ·
-
nightly-testing
Difficulty 4/5 3-5 days Newbie friendliness 25/100
firebase/firebase-cpp-sdk#1859 ·
All issues in firebase/firebase-cpp-sdk
Similar issues
-
bug build
Difficulty 1/5 Under an hour Newbie friendliness 91/100
facebookincubator/velox#19194 ·
-
JIT-compiled number -> Decimal conversion silently overflows instead of raising DECIMAL_OVERFLOW Openfuzz
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
ClickHouse/ClickHouse#122114 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
module/agent platform/macos type/bug/regression
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
enhancement PyCDE
Difficulty 2/5 1-3 hours Newbie friendliness 78/100