[FR] Open up FirebaseMessagingException
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
Research direction
Start by locating FirebaseMessagingException and reviewing its constructors and existing tests. Confirm that tests can instantiate exceptions for the UNREGISTERED and INVALID_ARGUMENT error codes while preserving the SDK's intended exception behavior; done when those scenarios are testable.
Written by the indexing model from the issue text.
Description
Is your feature request related to a problem? Please describe.
FirebaseMessagingException is final and has package private/private constructors. This prevents using the exception in tests. The firebase recommendation to deal with invalid tokens is to react on error code UNREGISTERED and INVALID_ARGUMENT. In order to test my code that deals with this scenario I would need to create a FirebaseMessagingException with the specified error codes which I can't.
Describe the solution you'd like
Open up FirebaseMessagingException to allow instantiation in tests.
- Dominant language
- Java
- Stars
- 620
- Forks
- 305
- Avg merge
- 4d 9h
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from firebase/firebase-admin-java
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
firebase/firebase-admin-java#1231 ·
-
api: core
firebase/firebase-admin-java#1198 · 3 comments · 1 assignee ·
-
api: remoteconfig
firebase/firebase-admin-java#1196 · 1 comment · 2 assignees ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
firebase/firebase-admin-java#1192 · 3 comments ·
-
needs-triage type: feature request
Difficulty 3/5 1-2 days Newbie friendliness 45/100
firebase/firebase-admin-java#1149 · 1 comment ·
All issues in firebase/firebase-admin-java
Similar issues
-
awaiting triage bug Causes friction Hop Gui P1 P2 Transforms
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
apache/flink-agents#1152 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
jenkinsci/blueocean-plugin#5417 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
objectionary/eo-graphs#75 ·