Auth list tenants is not pageable
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- java
- Domain
- api, authentication
Research direction
Start with FirebaseTenantClient.MAX_LIST_TENANTS_RESULTS and the TenantManager.listTenants call shown in the report. Run or inspect the existing ListTenantsPage pagination behavior, comparing it with the GCP Identity Platform request described. Done means tenants can be retrieved across all available pages without the SDK incorrectly preventing the required request.
Written by the indexing model from the issue text.
Description
- Firebase SDK version: 9.8.0
- Firebase Product: auth
Fetching tenants with firebaseAuth.getTenantManager().listTenants(null) does not return a PageToken even though more pages exist. There is no possibility to page through all tenants.
private List<Tenant> getAllTenants() {
ListTenantsPage listTenantsPage = null;
List<Tenant> allTenants = new ArrayList<>();
try {
do {
listTenantsPage = firebaseAuth.getTenantManager().listTenants(listTenantsPage == null ? null : listTenantsPage.getNextPageToken());
for (Tenant tenant : listTenantsPage.iterateAll()) {
allTenants.add(tenant);
}
log.info("Next page token: {}", listTenantsPage.getNextPageToken());
} while (listTenantsPage.hasNextPage());
} catch (FirebaseAuthException e) {
log.error("Could not list tenants", e);
}
log.info("Found {} tenants", allTenants.size());
return allTenants;
}
When viewing the tenants in the GCP Identity Platform, the same request is used with a page size of 2147483647. However, the admin sdk prevents requesting a page size over 100 (FirebaseTenantClient.MAX_LIST_TENANTS_RESULTS).
Please either remove the page size restriction in the sdk or fix pagination with page token of tenants
- Dominant language
- Java
- Stars
- 620
- Forks
- 305
- Avg merge
- 4d 9h
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from firebase/firebase-admin-java
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
firebase/firebase-admin-java#1231 ·
-
api: core
firebase/firebase-admin-java#1198 · 3 comments · 1 assignee ·
-
api: remoteconfig
firebase/firebase-admin-java#1196 · 1 comment · 2 assignees ·
-
needs-triage type: feature request
Difficulty 3/5 1-2 days Newbie friendliness 45/100
firebase/firebase-admin-java#1149 · 1 comment ·
-
needs-triage type: feature request
Difficulty 5/5 Over a week Newbie friendliness 45/100
firebase/firebase-admin-java#1142 · 2 comments ·
All issues in firebase/firebase-admin-java
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
elastic/gradle-plugins#157 ·
-
enhancement Tools
Difficulty 1/5 Under an hour Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
apache/rocketmq-dashboard#5008 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
DETECT_PARAMETER_NAMES=false silently disables @ConstructorProperties-based Creator detection too Open
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
FasterXML/jackson-databind#6229 ·