the code-connect fetch timeout is too short

Open
  • Is something wrong?
#336 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
node.js, typescript
Domain
cli, networking

Research direction

Start by locating the fetch implementation corresponding to node_modules/@figma/code-connect/dist/common/fetch.js in the repository, then read how CLI options are defined and passed to fetch. Check the existing fetch tests and add coverage for configuring the connection timeout; done means users can set the timeout and the tests verify it is applied.

Written by the indexing model from the issue text.

Description

API question

Please provide:

  • Code Connect CLI version [use npx figma -V if using React, or figma -V otherwise, to get the version of your CLI]
    v1.3.6
  • Operating system: WLS under windows

The fetch timeout is too short, it get timeout even I set batch size to 1

in the node_modules/@figma/code-connect/dist/common/fetch.js file I have to manually add

const customAgent = new undici_1.Agent({
  connect: {
    // Set the connection timeout to 30,000 ms (30 seconds)
    timeout: 30_000,
  }
});

then in the code where the fetch call is executed

const response = await fetch(url, { ...options, method, dispatcher:customAgent });

Please allow us to set the timeout value

Dominant language
TypeScript
Stars
1.6k
Forks
126
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from figma/code-connect

All issues in figma/code-connect

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.