Fehlede Eingabe Validierung führt zu Warninungs
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Start in lib/FHEM/Automation/ShuttersControl/Helper.pm around line 929 and trace how BlockingTimeAfterManual is parsed and compared. Reproduce the warning with the reported 0:20 value, then inspect the related attribute handling to determine where validation belongs. Done means invalid input is verified or rejected without producing the numeric-comparison warning.
Written by the indexing model from the issue text.
Description
Ich habe 0:20 - 20 Minuten - für BlockingTimeAfterManual hinterlegt.
Das führ zu einem Warning:
PERL WARNING: Argument "0:20" isn't numeric in numeric lt (<) at lib/FHEM/Automation/ShuttersControl/Helper.pm line 924.
In Version # $Id: Helper.pm 23934 2021-03-12 12:19:50Z CoolTux $
Ich nehme an, im Master branch entspricht das folgender Zeile:
Offensichtlich ist nicht vogesehen, dass in dem Feld eine Stunden:Minuten Angabe getätigt wird, dennoch wird der Parameter aber beim Eingeben angenommen.
Ich würde eine Validierung der Parameter empfehlen, dann könnten zumindest keine Fehlerhaften eingegeben werden.
Aus Sicht der Lib, wäre es aber auch wünschenswert, dass es eine Verifizierung gibt,
- Dominant language
- Perl
- Stars
- 9
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fhem/AutoShuttersControl
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
fhem/AutoShuttersControl#102 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
fhem/AutoShuttersControl#100 · 8 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
fhem/AutoShuttersControl#98 ·
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
fhem/AutoShuttersControl#88 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
fhem/AutoShuttersControl#84 ·
All issues in fhem/AutoShuttersControl
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
gugod/App-perlbrew#879 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
RotherOSS/otobo#6205 · 1 comment ·
Maintainers usually reply within 1 day
-
Add IO::Pipe classOpen
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
yuki-kimoto/SPVM-IO#30 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
fglock/PerlOnJava#1651 ·
Maintainers usually reply within 1 day