feat: flag resources missing the application tag

Open Beginner friendly
  • Is something wrong?
#166 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
aws, rust
Domain
cloud

Research direction

The issue points to src/app/findings.rs, resources_missing_owner_tag, and its tests; first read docs/recipes/README.md and the add-a-finding recipe, then check blocker #163 is merged. Add the application-tag predicate and rule, and update the roadmap and changeset. Done when the requested unit tests and full Rust formatting, clippy, and test commands pass.

Written by the indexing model from the issue text.

Description

size: XS

Why

An untagged resource is invisible to every cost and grouping tool. This mirrors the existing owner-tag rule.

Follow docs/recipes/add-a-finding.md.

Steps

  1. Copy resources_missing_owner_tag in src/app/findings.rs and its tests, using the configured application tag key.
  2. Rule resources_missing_application_tag (Hygiene, Medium). A resource whose tags could not be read must not be reported (the owner rule already handles this; keep that behavior).
  3. Tests.

Where to look

  • src/app/findings.rs (resources_missing_owner_tag)

Done when

  • Predicate on the model with unit tests (one firing case, one quiet case)
  • Rule added to FINDING_RULES with tests in src/app/findings.rs
  • docs/findings-roadmap.md lists the rule under Current Findings
  • Changeset added (minor)
  • cargo fmt --all, cargo clippy --all-targets -- -D warnings, and cargo test --all pass, with output pasted in the PR

Check against AWS

Optional. Unit tests are enough for this issue.

Blocked by

#163. Start this after that is merged.

Size: XS. Read docs/recipes/README.md before starting.

Dominant language
Rust
Stars
2
Forks
0
Avg merge
4h 8m
Merged PRs (30d)
8

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fells-code/seamless-glance

All issues in fells-code/seamless-glance

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.