[BUG] Vulkan: driver name of a previous device is concatenated on multi-GPU systems
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 88/100
Research direction
Start in src/detection/vulkan/vulkan.c, reading detectVulkan and applyDriverName alongside the existing overwrite comment. Reproduce with fastfetch -s vulkan --pipe -l none on a multi-GPU system, then verify that the displayed driver name is only that of the device with the highest API version and is not concatenated with an earlier device name.
Written by the indexing model from the issue text.
Description
- I have checked the FAQ but the issue is not covered
Description
On a system with two Vulkan devices, the Vulkan module prints the driver names of both devices glued together:
$ fastfetch -s vulkan --pipe -l none
Vulkan 1.4.354 - NVIDIA [615.71.09]radv [Mesa 26.2.2-arch1.1]
Expected: radv [Mesa 26.2.2-arch1.1], the driver of the device with the highest API version.
In detectVulkan (src/detection/vulkan/vulkan.c), the comment says the driver name should be overwritten whenever a device with a higher API version is found:
// If the device api version is higher than the current highest device api version, overwrite it
// In this case, also use the current device driver name as the shown driver name
However, applyDriverName only appends to result with ffStrbufAppendS and never clears it first. The NVIDIA device is enumerated first and sets the name. The RADV device comes second with a higher API version, and its name is appended to the NVIDIA one instead of replacing it.
As far as I can tell this has been the case since the Vulkan module was added. It only shows up when the device with the highest API version is not the first one enumerated.
A PR with the fix follows: it clears the buffer at the start of applyDriverName.
Version used: fastfetch 2.68.1 (Arch package); also reproduced on dev @ 9801d89 built from source
Bug prevalence: Always
Regression: No
Installation: Package manager
Package manager: pacman
System information
OS Arch Linux (rolling), kernel 6.18.52-1-lts, x86_64
GPU 1 AMD Raphael [Integrated] (Vulkan driver: radv, Mesa 26.2.2)
GPU 2 NVIDIA GeForce RTX 5060 [Discrete] (Vulkan driver: NVIDIA 615.71.09, nvidia-open)
- Dominant language
- C
- Stars
- 24.8k
- Forks
- 908
- Avg merge
- 22h 1m
- Merged PRs (30d)
- 22
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fastfetch-cli/fastfetch
-
logo request
Difficulty 1/5 Under an hour Newbie friendliness 90/100
fastfetch-cli/fastfetch#2607 ·
Maintainers usually reply within 1 day
-
logo request
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
fastfetch-cli/fastfetch#2590 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
fastfetch-cli/fastfetch#2587 · 1 comment ·
Maintainers usually reply within 1 day
-
logo request
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
fastfetch-cli/fastfetch#2568 ·
Maintainers usually reply within 1 day
-
[LOGO] EnderOSOpenlogo request
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
fastfetch-cli/fastfetch#2556 ·
Maintainers usually reply within 1 day
All issues in fastfetch-cli/fastfetch
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
python-pillow/Pillow#10087 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
OpenPrinting/cups#1729 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
awslabs/amazon-kinesis-video-streams-webrtc-sdk-c#2406 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
DaveGamble/cJSON#1094 ·
-
status:needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
PX4/PX4-Autopilot#28923 ·
Maintainers usually reply within 1 day