OAuthAccount.expires_at should be BigInteger
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Domain
- authentication, backend
Research direction
Start by locating the OAuthAccount.expires_at model field and reproduce the database insert with an OAuth2 provider returning a large expiration timestamp, such as the ORCID sandbox. Change the field to support dates in 2043 and verify that authentication and database insertion succeed without the integer overflow failure.
Written by the indexing model from the issue text.
Description
Describe the bug
The OAuthAccount.expires_at field is an Integer. If your OAuth2 provider decides to give you a value in 2043 (as ORCID sandbox does) then this cannot be inserted into the database any more.
To Reproduce
Steps to reproduce the behavior:
- Setup fastapi-users with OAuth2.
- Authenticate with a provider who returns a sufficiently large
expires_atvalue. - Database insert will fail.
Expected behavior
Dates in 2043 should work.
Configuration
- Python version : 3.11
- FastAPI version : 0.103.1
- FastAPI Users version : 12.1.2
FastAPI Users configuration
N/A
Additional context
N/A
- Dominant language
- Python
- Stars
- 6.2k
- Forks
- 511
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from fastapi-users/fastapi-users
-
bug
Difficulty 1/5 1-3 hours Newbie friendliness 72/100
fastapi-users/fastapi-users#1559 · 1 comment · 1 reaction ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
fastapi-users/fastapi-users#1523 · 2 comments ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 35/100
fastapi-users/fastapi-users#1440 · 3 comments ·
All issues in fastapi-users/fastapi-users
Similar issues
-
adr
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
kristofdegrave/homeassistant-smart-charging#1607 ·
Maintainers usually reply within 1 day
-
namespace operations
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
EclipseFdn/open-vsx.org#13665 ·
Maintainers usually reply within 1 day
-
doc good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
collective/icalendar#1865 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
canonical/opentelemetry-collector-operator#409 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
mozilla/addons-release-tests#1243 ·
Maintainers usually reply within 1 day