COctet String : max length

Open
  • Is something wrong?
#216 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
28/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript, node.js
Domain
backend, networking

Research direction

Start by reading defs.types and the SMPP specification for C-Octet String field limits, using bind_transmitter.password as the example. Clarify whether the intended change is to represent maximum lengths in the type definitions, enforce them during encoding, or both; the issue does not define acceptance criteria or name existing tests.

Written by the indexing model from the issue text.

Description

Hi @farhadi and maintainers,
Unless I am wrong the lib is not considering the field size as per SMPP specification.
For example, "bind_transmitter.password" is "C-Octet String" with max length = 9. Am I correct ?
If so, is it intentional or maybe planned in future release ?
I noticed that all types are statically defined in "defs.types".
What would be the best way to implement such evolution ?
Thanks a lot for your support

Dominant language
JavaScript
Stars
434
Forks
194
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from farhadi/node-smpp

All issues in farhadi/node-smpp

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.