Dead code sweep (Python): legacy phase-based hook engine, tests-only helpers, unused --no-config-propose flag
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 70/100
Research direction
Start by reading core/environment/execution.py and the listed test callers to confirm the hook engine is test-only. Remove the dead functions from core/config/loader.py, utils/network.py, core/processing/* and others, plus the --no-config-propose flag in app.py. Migrate tests off profiles/config.py shim and delete temp_test/; run the suite to confirm no references remain and tests pass.
Written by the indexing model from the issue text.
Description
Verified production-dead (grep across src/ + tests/; "tests-only" = kept alive only by tests and re-exports):
Decide: legacy phase-based hook engine. core/environment/execution.py (parse_hook_entries, run_blocking_hook, spawn_background_hook, run_hooks_for_file, HookOutcome), HookSpec (core/config/models.py:96-116), HookEntry (core/config/schema.py:61-67, labelled "legacy phase-based"). Only callers are tests/core/environment/test_execution.py + re-exports (environment/__init__.py:11-16, core/__init__.py:46-47). Production uses the step-based run_workflow. Delete now, or batch with the gui/ removal (phase-2 tracking issue).
Certain production-dead functions (drop, plus their tests):
propose_config_creation—core/config/loader.py:46-89(superseded bylaunch/creation.propose_creation+--init)load_column_rules_from_config—core/processing/column_extractor.py:256(parses a legacyCOLUMN_DEFINITIONSstring format nothing produces anymore)get_system_info—utils/network.py:65-76(duplicate ofcore/environment/system.collect_system_info)list_directory_paths—utils/file_utils.py:481-490log_rotated—core/telemetry/events.py:67(diagnostics.py:116emits the same event directly — one mechanism should win)get_file_info_dynamic—core/processing/file_classifier.py:176ScanMetrics.to_dict—core/telemetry/metrics.py:32-41(zero callers anywhere)
CLI/config leftovers
--no-config-proposeflag stored (app.py:605-610,:110) but never read — the comment atapp.py:252-255admits the behavior moved.AppConfig.skip_config_prompt(models.py:280) read only by gui/ — dies with the gui removal.
Test-side orphans
profiles/config.pyshim imported only by tests — migrate tests to real module paths and delete.- Unused conftest fixtures
sample_config_path/empty_config_path(tests/conftest.py:17-57). - Registered marker
qt_no_exception_capture(pyproject.toml:218-220) but pytest-qt is not a dependency anywhere — remove the marker, or add the dep. - Tracked scratch file
temp_test/web/package.json—git rmthe wholetemp_test/directory. tests/core/config/test_models_refactored.py,test_reader_refactored.py,tests/core/processing/test_column_extractor_refactored.pysit next to their originals — merge or delete the leftovers.
Note: the 14 gui-only telemetry helpers (app_closed, filter_changed, …) are intentionally not in this list — they die with the gui/ phase-2 removal.
- Dominant language
- Python
- Stars
- 1
- Forks
- 1
- Avg merge
- 4h 46m
- Merged PRs (30d)
- 55
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from falbany/ProFiles
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
falbany/ProFiles#187 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in falbany/ProFiles
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
ip-tools/patzilla#219 · 2 comments ·
Maintainers usually reply within 1 day
-
EPSSClient commits to its SQLite cache once per score: a 100-CVE bulk fetch makes 101 disk flushesOpenpriority:p3 technical-debt
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
jimmy058910/jmo-security-repo#1673 ·
Maintainers usually reply within 1 day
-
enhancement ready
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
integration: frontier_silicon
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
home-assistant/core#193176 · 2 comments ·
Maintainers usually reply within 1 day
-
task create and task update take --body-file and --stdinPossibly taken @JuanBarriosS claimed this today. Opencli enhancement good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
pyrite-wiki/pyrite#1687 · 1 comment ·
Maintainers usually reply within 1 day