Security: path traversal in the SPA static fallback route — arbitrary file read as the running user

Open Beginner friendly
#28 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@phatloi0010 is already working on this.

Since Nov 2, 2026.

  • #77 by @phatloi0010 — open

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
85/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
backend, security

Research direction

Read src/profiles/server/static.py lines 27-35 to see the unprotected catch-all that builds FileResponse from static_dir / full_path. The fix must add .resolve() and prefix containment, then add a regression test that sends ..%2f paths and expects them to fall through to index.html rather than escape the dist dir. Done means no arbitrary file read and test passes.

Written by the indexing model from the issue text.

Description

bug security

Summary

src/profiles/server/static.py:27-35 — the hand-rolled SPA catch-all serves any file at static_dir / full_path after only an is_file() check. There is no .resolve() + prefix containment, and uvicorn/starlette percent-decode request paths, so:

GET /..%2f..%2f..%2fetc%2fpasswd

escapes static_dir and is returned via FileResponse. The /assets mount (static.py:22-24, Starlette StaticFiles) is traversal-protected — only the hand-rolled catch-all is vulnerable. Combined with the unauthenticated CORS posture (see companion issue), any webpage (or, on --server-only, any LAN host) can read arbitrary files readable by the user.

Suggested fix

requested = (static_dir / full_path).resolve()
if requested.is_file() and requested.is_relative_to(static_dir.resolve()):
    return FileResponse(requested)

plus a regression test hitting ..%2f paths that must fall through to index.html (404/SPA), not escape the dist dir.

Dominant language
Python
Stars
1
Forks
1
Avg merge
4h 46m
Merged PRs (30d)
55

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from falbany/ProFiles

All issues in falbany/ProFiles

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.