web: add @vitest/coverage-v8 and close the component test gap — 22 of 26 components have zero tests
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 55/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- python, react, typescript
- Domain
- testing
Research direction
Start with src/profiles/web/vitest.config.ts and src/profiles/web/package.json to see how the web tests and scripts are configured; the issue also names ConfigEditorModal.test.tsx and five components to prioritize. Add coverage support and tests for the listed components, then replace the stylesheet text assertions with behavior or class checks. Done means coverage runs successfully and the targeted tests cover the specified behavior.
Written by the indexing model from the issue text.
Description
Problem
The Python side enforces --cov-fail-under=85, but the web suite has no coverage provider at all — npm test -- --coverage fails with "missing @vitest/coverage-v8". AGENTS.md's ">85% coverage" target is unenforceable for src/profiles/web (extends #41, which added the test infra, and #48, which gates CI).
Tested today: ConfigEditorModal, CopyableUrl, MarkdownMessage, SaveAsDialog, StatusBar, WorkflowRunnerModal, App.configEditor (editor slice only), utils barcodeDecoder/configDrop/fileProperties/searchSyntax/theme/useModalA11y, api/client.
Untested (22 components): ActionBar, BarcodeModal, CameraBarcodeModal, ConfirmDialog, ContextMenu, DirectoryPickerModal, DropConfigOverlay, EditableCombobox, ErrorBoundary, FileListTable, FilePropertiesModal, FilterSyntaxHelper, HeaderBar, InitErrorPanel, LoadConfigModal, LogViewerModal, ScanStatusStrip, SearchBar, ShortcutsModal, SingleMatchPromptModal, TimerModal, Tooltip. Untested utils: exportCsv.ts, barcodeScanner.ts.
Smell: ConfigEditorModal.test.tsx:1083,1142 asserts on raw stylesheet text — readFileSync(join(process.cwd(), "src", "index.css"), "utf8") — coupling tests to CSS string content (any reformat breaks the suite) and to the cwd.
Suggested fix
- Add
@vitest/coverage-v8, a"test:coverage"script and acoverageblock invitest.config.ts(includesrc/**, exclude*.test.*anddist); reference it in the future CI web job (#48). - Prioritize behavior-bearing untested components for tests: EditableCombobox, DirectoryPickerModal, LoadConfigModal, DropConfigOverlay, FileListTable.
- Replace the CSS
readFileSyncassertions with class-presence/behavior assertions or delete them.
- Dominant language
- Python
- Stars
- 1
- Forks
- 1
- Avg merge
- 4h 46m
- Merged PRs (30d)
- 55
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from falbany/ProFiles
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
falbany/ProFiles#187 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in falbany/ProFiles
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
ip-tools/patzilla#219 · 2 comments ·
Maintainers usually reply within 1 day
-
EPSSClient commits to its SQLite cache once per score: a 100-CVE bulk fetch makes 101 disk flushesOpenpriority:p3 technical-debt
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
jimmy058910/jmo-security-repo#1673 ·
Maintainers usually reply within 1 day
-
enhancement ready
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
integration: frontier_silicon
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
home-assistant/core#193176 · 2 comments ·
Maintainers usually reply within 1 day
-
task create and task update take --body-file and --stdinPossibly taken @JuanBarriosS claimed this today. Opencli enhancement good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
pyrite-wiki/pyrite#1687 · 1 comment ·
Maintainers usually reply within 1 day