Hygiene: tsconfig.tsbuildinfo is tracked and churns every build; stale log files in web source tree; CWD-relative logger defaults; dead ValidateRequest.filename; AGENTS.md utils tree missing path_utils.py

Open
#149 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
45/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
python, typescript, vite

Research direction

Start by checking the listed files and paths: src/profiles/web/package.json, both logger definitions in core/telemetry/diagnostics.py, src/profiles/web/routes/config.py, client.ts, and the Utils Layer tree in AGENTS.md. Verify each reported issue against the repository and its current references before changing it. Done means the tracked build artifact and stale logs are addressed, logger defaults no longer write relative to the working directory, the unused request field is resolved, and the documented tree includes path_utils.py.

Written by the indexing model from the issue text.

Description

code-quality

Hygiene sweep (all git/read verified)

  1. tsconfig.tsbuildinfo tracked in git — written by "build": "tsc -b && vite build" (package.json:7); tsc -b always emits it. Not covered by any .gitignore (git check-ignore → NOT IGNORED), committed historically and drifting on every local build. Fix: git rm --cached src/profiles/web/tsconfig.tsbuildinfo + add *.tsbuildinfo to src/profiles/web/.gitignore.

  2. Stray logs in the package source dir — src/profiles/web/profiles.log (Oct 15, legacy CWD-relative write), test-output.log + test-output2.log (Nov 3 manual npm test > … redirections, no script references them). They are untracked and ignored, but they signal a latent foot-gun: LoggerFactory.__init__ (core/telemetry/diagnostics.py:163) and configure_logger (diagnostics.py:281) still default to log_path="profiles.log" (CWD-relative) — any future caller of get_logger() without an explicit path reintroduces CWD log litter. Fix: delete the three files; change both signature defaults to log_path=None resolving to default_log_path() (mirroring app.py:120).

  3. ValidateRequest.filename is a dead contract field — declared in routes/config.py:39-41, dutifully sent by the client (client.ts:225-236), but validate_config_endpoint only uses payload.content (config.py:360-368). Drop it (or actually use it in issue messages).

  4. AGENTS.md tree missing src/profiles/utils/path_utils.py — the Utils Layer section lists only file_utils.py, network.py, search_parser.py, shortcut.py, while path_utils.py (home of normalize_user_path, imported by the config routes) exists — exactly the stale-import-path hazard the AGENTS.md "Keep in sync" note warns about. Add it to the tree.

Dominant language
Python
Stars
1
Forks
1
Avg merge
4h 46m
Merged PRs (30d)
55

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from falbany/ProFiles

All issues in falbany/ProFiles

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.