server: drag-drop config path — fail-fast single-issue validation, unbounded drop payload, .yaml/.yml whitelist asymmetry

Open
#138 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
javascript, python, yaml
Domain
api, backend, frontend

Research direction

Start with web/src/utils/configDrop.ts, routes/config.py, core/config/diagnostics.py, and config.py; trace the drop, content-load, validation, disk-load, and Save As paths. Compare collect_config_issues with ConfigReader.from_content, then inspect the existing suffix rules and request handling. Done means dropped drafts report all validation issues, oversized payloads are limited, and drop, load, and Save As accept consistent extensions; also check the multi-file drop behavior.

Written by the indexing model from the issue text.

Description

bug code-quality

Problem

End-to-end walk of the drag-drop-config path (web/src/utils/configDrop.ts → POST /api/config/load-content → ConfigReader.from_content):

  1. Validation gap. The drop endpoint validates via ConfigReader.from_content, which is deliberately fail-fast ("raises on the first problem", per its own docstring and the header of core/config/diagnostics.py) — a dropped draft with 4 problems reports only the first, while the editor's /validate path returns all issues via collect_config_issues (already wired into validate_issues at routes/config.py:187-203). Same data, two reporting modes; #111 made the editor multi-issue but the drop path did not follow.
  2. Size/encoding guard. handleDroppedConfig reads await file.text() with no size limit and POSTs it as one JSON body; the server accepts any body size. Dropping a multi-hundred-MB .yaml freezes the tab and spikes server memory.
  3. Whitelist asymmetry. Drops accept .yaml/.yml (_ACCEPTED_DROP_SUFFIXES, routes/config.py:237-243), but SAVE_AS_EXTENSIONS (config.py:481) only allows .profiles/.profiles.yaml — a user who drops my.yaml, edits it, then presses Save As is forced to rename; and POST /config/load (disk path) rejects .yaml/.yml too (_is_config_path, config.py:64-73), so a .yml trial cannot be re-opened from disk.
  4. Minor: pickConfigFile (configDrop.ts:23-30) silently drops all but the first accepted file in a multi-file drop.

Suggested fix

  1. In load_content_endpoint, build the 400 detail from collect_config_issues(payload.content) instead of the first ValueError.
  2. Add a client-side size check (e.g. 2 MB) in handleDroppedConfig and a server body limit.
  3. Align the three whitelists (drop / load / save-as) on one shared tuple.
  4. Surface "N of M files ignored" or pick by extension priority in pickConfigFile.
Dominant language
Python
Stars
1
Forks
1
Avg merge
4h 46m
Merged PRs (30d)
55

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from falbany/ProFiles

All issues in falbany/ProFiles

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.