server: GET /api/config first-paint directory selection diverges from launch resolution; GET mutates ServerState; phantom config_path for trials
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 55/100
Research direction
Start with routes/config.py, especially _config_response and _choose_active_directory, then read config_service.choose_active_directory in service.py and the trial handling in /load-content and /content. Trace how ServerState initializes its config and active directory before moving initialization out of the GET handler. Done when first paint follows launch directory selection, GET has no state mutations, and trial responses identify the session and return config_path: None.
Written by the indexing model from the issue text.
Description
Problem
Two divergent selection algorithms coexist in routes/config.py:
_choose_active_directory(used by load/drop/create/reload) calls the core single-source-of-truthconfig_service.choose_active_directory("Single source of truth shared by desktop launch resolution and the server's config load/drop endpoints",service.py:178-180).- But the first-paint fallback inside
_config_responsehand-rolls its own (config.py:99-116):
selected = config_service.auto_select_directory(cfg, hostname) # display-name match, no search_dir preference
if selected and Path(selected).exists():
state.active_directory = Path(selected)
elif available_dirs:
state.active_directory = Path(available_dirs[0])
auto_select_directory returns a machine display name or first scan path (never search_dir first, no existence ranking), while choose_active_directory prefers search_dir then hostname-matched scan dirs. A config with search_dir=D1 and a hostname-matched machine scanning D2 launches on D1 but the web session's first GET /api/config activates D2 — session behavior diverges from launch behavior until a load/reload normalizes it.
Additionally:
GET /api/config(a read) mutatesstate.config_path,cfg.config_pathandstate.active_directory(side effects in a GET handler).- The response never includes
session_trial(only/load-contentappends it,config.py:277), so after a page refresh the UI cannot tell it is on a trial — yet the response still advertises"config_path": str(phantom)and"config_exists"for that phantom (config.py:131-132), contradictingGET /content's carefulconfig_path: Nonefor trials (config.py:390-396).
Suggested fix
- Replace the hand-rolled block with
_choose_active_directory(cfg, None). - Move the initial-state derivation into a ServerState/bootstrap method instead of a GET handler.
- Include
session_trial(andconfig_path: Nonefor trials) in_config_response.
- Dominant language
- Python
- Stars
- 1
- Forks
- 1
- Avg merge
- 4h 46m
- Merged PRs (30d)
- 55
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from falbany/ProFiles
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
falbany/ProFiles#187 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in falbany/ProFiles
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
ip-tools/patzilla#219 · 2 comments ·
Maintainers usually reply within 1 day
-
EPSSClient commits to its SQLite cache once per score: a 100-CVE bulk fetch makes 101 disk flushesOpenpriority:p3 technical-debt
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
jimmy058910/jmo-security-repo#1673 ·
Maintainers usually reply within 1 day
-
enhancement ready
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
integration: frontier_silicon
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
home-assistant/core#193176 · 2 comments ·
Maintainers usually reply within 1 day
-
task create and task update take --body-file and --stdinPossibly taken @JuanBarriosS claimed this today. Opencli enhancement good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
pyrite-wiki/pyrite#1687 · 1 comment ·
Maintainers usually reply within 1 day