Web UI: global keyboard shortcuts stay live behind the config editor and LAN dialogs — typing "p"/Enter launches files or opens dialogs
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- react, typescript
Research direction
Start in src/profiles/web/src/App.tsx at the anyModalOpen list and global keydown handler; then read ConfigEditorModal.tsx around its Ctrl/Cmd+S capture listener. Check how the config editor and LAN confirmation are represented, and whether editable targets are skipped. Done means global shortcuts no longer act behind either surface or while typing in editable content.
Written by the indexing model from the issue text.
Description
Problem
The shortcut-suppression list covers 12 surfaces but omits the config editor and the LAN confirmation dialog:
// src/profiles/web/src/App.tsx:1223-1236
const anyModalOpen = Boolean(
contextMenuPos || showShortcuts || showDirPicker || … || Boolean(pendingDeleteFile),
);
While the ConfigEditorModal is open, CodeMirror's .cm-content is a contenteditable div, so neither guard in the keydown handler applies: the HTMLInputElement/HTMLSelectElement check (App.tsx:1271) and the closest("button, a, [role='menuitem']…") check (App.tsx:1265) both miss it. With text focused in the editor:
- "p" → opens the File Properties modal (
App.tsx:1386-1393) - Enter →
handleExecute()launches the currently selected file (App.tsx:1437-1440) - arrows/PageUp/PageDown move the hidden file list; F5 rescans; Ctrl+R reloads the config mid-edit; "?" opens the Shortcuts modal
The editor's own capture listener only guards Ctrl/Cmd+S (ConfigEditorModal.tsx:918-935).
The same gap applies to lanPending (LAN toggle ConfirmDialog, App.tsx:1722-1785) — plain keys drive the app behind a security-relevant confirmation.
Suggested fix
- Add
showConfigEditorandlanPending !== nulltoanyModalOpen. - Additionally skip the shortcut block when
target.isContentEditableis true (defends every future editor surface).
- Dominant language
- Python
- Stars
- 1
- Forks
- 1
- Avg merge
- 4h 46m
- Merged PRs (30d)
- 55
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from falbany/ProFiles
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
falbany/ProFiles#187 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
bug frontend
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in falbany/ProFiles
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
ip-tools/patzilla#219 · 2 comments ·
Maintainers usually reply within 1 day
-
EPSSClient commits to its SQLite cache once per score: a 100-CVE bulk fetch makes 101 disk flushesOpenpriority:p3 technical-debt
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
jimmy058910/jmo-security-repo#1673 ·
Maintainers usually reply within 1 day
-
enhancement ready
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
integration: frontier_silicon
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
home-assistant/core#193176 · 2 comments ·
Maintainers usually reply within 1 day
-
task create and task update take --body-file and --stdinPossibly taken @JuanBarriosS claimed this today. Opencli enhancement good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
pyrite-wiki/pyrite#1687 · 1 comment ·
Maintainers usually reply within 1 day