ResultsContainer

Open
  • Is something wrong?
#157 0 comments 0 reactions 1 assignee View on GitHub

@Brymon is already working on this.

Since Oct 19, 2018.

Assessment

This issue has not been assessed yet.

Description

refactoring

Just dumping a few things I noticed in this component:

Duplicating the array of elements here isn't required because both filter and map return new arrays so you aren't modifying the original props anyway.

Using an index as a key is generally an antipattern though I think you're ok here because you aren't changing the list once rendered.

You seem to have a lot of duplicated IDs on tags - is that intentional? IDs should be unique. One #revision-list is the actual list of missed items but the other one seems to be the score so I'm not sure why it's a list.

Dominant language
JavaScript
Stars
4
Forks
2
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from fac-14/OSCEBossKey

All issues in fac-14/OSCEBossKey

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.