Why is int32ToString needed for numeric props? (SolidJs)
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Refactor
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- fsharp
- Domain
- frontend
Research direction
Start with src/Feliz.JSX.Solid/Attribute.fs around line 1379 and reproduce the behavior using the linked Solid playground. Compare the generated handling of numeric props with SolidJS expectations; done means the reason for int32ToString is documented or the unnecessary conversion is removed with a regression check.
Written by the indexing model from the issue text.
Description
Why is int32ToString needed for numeric props? (SolidJs)
Doesn't Solid work well directly with numeric values in props ?
e.g. Attr.x1
test: https://playground.solidjs.com/anonymous/7523d6dc-9e88-43ab-a493-5421c9482aa4
- Dominant language
- F#
- Stars
- 34
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
openremote/openremote#3487 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
coollabsio/jean#867 ·
Maintainers usually reply within 1 day
-
affected/v17 area/frontend type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
umbraco/Umbraco-CMS#24323 · 1 comment ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
nunomaduro/dev-null.sh#1161 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day