`ghstack submit --update-fields` created a new pull request if the ghstack info is damaged or missing
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start at the ghstack submit --update-fields entry point and reproduce the case with a damaged or missing Pull Request resolved value in the commit message. Review how the command handles the shown URL form versus the numeric form; done requires an agreed behavior, either failing safely or updating only an existing pull request.
Written by the indexing model from the issue text.
Description
This might not be expected behavior. Two other possibilities are that ghstack submit --update-fields fails if the ghstack info in the commit message is damaged or missing, or to create another flag --update-only/-U, with this behavior.
I'd be willing to submit a pull request for either one of these behaviors if there were interest.
This happened when I restored my ghstack info from a branch as:
ghstack-source-id: de78c83d0763391c27c41501f614fafd49c9395c
Pull Request resolved: #128416
instead of
ghstack-source-id: de78c83d0763391c27c41501f614fafd49c9395c
Pull Request resolved: https://github.com/pytorch/pytorch/pull/128416
- Dominant language
- Python
- Stars
- 1k
- Forks
- 84
- Avg merge
- 10m
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ezyang/ghstack
-
Difficulty 4/5 3-5 days Newbie friendliness 28/100
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
LearningCircuit/local-deep-research#7206 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
chingu-voyages/V62-tier3-team-33#285 ·
Maintainers usually reply within 1 day
-
Proxy drops log notifications from backends that don't send FastMCP's msg/extra dictPossibly taken @asasemahmed claimed this today. Openbug server
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
[Bug]: Bedrock request metadata forwarding does not work for /embeddingsPossibly taken A pull request linked to this issue is open or already merged. Openbug llm translation
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day