The Great Monkey-Patch Safari

Open
#6,669 3 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Domain
api, backend

Research direction

Start by reviewing the references to IncomingMessage, ServerResponse, on-headers, and res.writeHead, including the linked security advisory, then inspect Express and its core dependencies for related monkey-patching. Done means collecting the identified instances in one place so maintainers can discuss how to address them.

Written by the indexing model from the issue text.

Description

discuss

We want to track down and document all instances of express and our core deps monkey-patching Node core, specifically it's the HTTP internals like IncomingMessage and ServerResponse where we do our monkey patching. So far as Im aware at least!

The goal being to collect them in one place, decide how to deal with them, push anything we can to node core or otherwise eliminate them.

This is a stub issue rn, hoping folks can collaborate and report places where we do this so we can track and discuss them. I have an actual write up about these issues, some history, and specifics that I'll dig up and probably edit into this or otherwise link to.

I am aware of specifically on-headerss and the res.writeHead we realized during https://github.com/jshttp/on-headers/security/advisories/GHSA-76c9-3jph-rj3q

What else?

Our practice of extending the proto of IncomingMessage and ServerResponse to create our (req, res) also falls into this category

Dominant language
JavaScript
Stars
69.7k
Forks
25.6k
Avg merge
2d 9h
Merged PRs (30d)
4

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from expressjs/express

All issues in expressjs/express

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.