Support CipherKey type for secret
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript, nodejs
Research direction
Start with index.js around line 33 and compare the current secret handling with cookie-signature's accepted key types and Node.js crypto.CipherKey documentation. Done means supporting the requested CipherKey-compatible secret values instead of only strings or string arrays while preserving existing cookie parsing and signing behavior.
Written by the indexing model from the issue text.
Description
Currently, only string or string array types can be used as secret values.
But cookie-signature allows not only string, but also ArrayBufferView(TypedArray, DataView), and crypto.KeyObject.
The secret is for an HMAC key, so technically we can allow string, ArrayBuffer, Buffer, TypedArray, DataView, KeyObject, and CryptoKey, which is described in the nodejs docs. And these types are represented as crypto.CipherKey type.
This is also related to security concerns. See Using strings as inputs to cryptographic APIs
- Dominant language
- JavaScript
- Stars
- 2k
- Forks
- 237
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from expressjs/cookie-parser
-
question
Difficulty 4/5 3-5 days Newbie friendliness 35/100
expressjs/cookie-parser#168 · 5 comments ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
expressjs/cookie-parser#138 ·
-
req.cookies is showing nullPossibly taken @D-393Patel claimed this 372 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 35/100
expressjs/cookie-parser#128 ·
-
perf: limit cookie parse only on some cookiePossibly taken @cesco69 claimed this 584 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 42/100
expressjs/cookie-parser#126 · 1 reaction ·
-
future question
Difficulty 5/5 Over a week Newbie friendliness 25/100
expressjs/cookie-parser#124 · 7 reactions ·
All issues in expressjs/cookie-parser
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
anothaDev/luci-theme-vantage#143 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
kingcharleslzy-ai/dsh-purge#282 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
-
a-corriger bug
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
christian-raj/S-Aloha#340 ·
-
area:image documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day