Update binary search tree documentation

Open
#1,809 5 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
35/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
haskell
Domain
testing-qa

Research direction

Open the linked exercises/practice/binary-search-tree/test/Tests.hs at line 35 and review the assertion for bstLeft alongside the duplicate-insertion case and bstValue check. Done means the test expectation reflects that inserting a duplicate value has no effect, with the relevant test passing.

Written by the indexing model from the issue text.

Description

In the tests for the binary-search-tree exercise, I think this assertion may be wrong as inserting a duplicate value into a BST has no effect (as checked by bstValue t shouldBe Just 4) and therefore I believe that bstLeft should be Nothing.

https://github.com/exercism/haskell/blob/23a8841dc163c0f82b9b999a16d5cf41e77c0fe3/exercises/practice/binary-search-tree/test/Tests.hs#L35

Dominant language
Ruby
Stars
362
Forks
566
Avg merge
15h 13m
Merged PRs (30d)
8

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from exercism/problem-specifications

All issues in exercism/problem-specifications

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.