"The remainingMinutesInOven method should reuse the logic implemented in expectedMinutesInOven" should take into account fields of the class.

Open
#218 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
java
Domain
tooling

Research direction

No file, test, or entry point is named. First locate the analyzer rule that produces the recommendation for the remainingMinutesInOven and expectedMinutesInOven methods, then review the exercise's class fields and existing tests. Done means the recommendation accurately reflects the intended field usage and the relevant analyzer tests pass.

Written by the indexing model from the issue text.

Description

Hello there!
I got the recommendation I put into the title for this exercise. I think this recommendation seems to be wrong. The method remainingMinutesInOven() is a getter method, as it only returns a predefined value.
Do you really reuse getter methods in other class methods to use said value?
Storing the value in a field and using said field in other classes seems to be the more effecient way in my eyes and is thus a slightly misleading recommendation, I think.
image

Dominant language
Java
Stars
13
Forks
27
Avg merge
4d 17h
Merged PRs (30d)
7

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from exercism/java-analyzer

All issues in exercism/java-analyzer

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.