semantic-release should not commit to master

Open
#21 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
ci-cd, release

Research direction

Locate the semantic-release configuration and release workflow; start by tracing how the publish step currently updates master and how CI is triggered. Done means releases use a release branch, open a PR containing the changelog changes, and CI ignores that PR.

Written by the indexing model from the issue text.

Description

triage

Is your feature request related to a problem? Please describe.
At the moment, when semantic release is doing the publish step, it includes the changelog.

However, it also commits the changelog, and pushes this commit to master. Since master should be a protected branch, this presents some challenges that force us to loosen the rules, and to put powerful tokens in sketchy places.

Describe the solution you'd like
semantic-release should do everything on a release branch, opening a PR with the results instead of pushing them directly to master. This PR should be ignored by CI.

Describe alternatives you've considered
I've tried nothing and I'm all out of ideas.

Additional context
Perfection is the goal here ladies & non ladies.

Dominant language
JavaScript
Stars
3
Forks
2
PR merge metrics
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from etclabscore/pristine-typescript

All issues in etclabscore/pristine-typescript

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.