Decide whether to request Copilot reviews on every esphome/esphome PR
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 8/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Active
- Tech stack
- github-actions
- Domain
- ci-cd
Research direction
This is a policy question, not a code change, and it has no comments yet. Read the referenced request-copilot-review.yml in esphome/devices.esphome.io and the dev ruleset in esphome/esphome, plus esphbot's review setup, to understand the trade-offs. Done means the maintainers have recorded a decision, not that code has changed. Contributors should coordinate with maintainers before doing anything.
Written by the indexing model from the issue text.
Description
Summary
Should esphome/esphome request a Copilot review on every contributor PR, the way the smaller repos now do? It was not proposed for the main repo yet. If the answer is "not yet", this issue is a placeholder to check again later.
Why the smaller repos have it
On the smaller repos a workflow requests a Copilot review on every contributor PR. That was clearly worth it: those PRs got no review at all before, and contributors would give up and disappear because they heard nothing back. Any feedback that is somewhat helpful beats months of silence, and the PR is usually in better shape by the time a maintainer gets to it. Maintainers look at esphome/esphome PRs much more often, so the trade-off there is different, and Copilot's reviews keep getting better.
Where things stand
- esphome/esphome has the Copilot review rule in its
devruleset (review when a PR is opened or marked ready, not on later pushes, not on drafts). The rule runs the review as the PR author, so a contributor without a Copilot seat gets no review at all. Only authors with a seat get one. - devices.esphome.io, device-builder, device-builder-frontend and aioesphomeapi run a
request-copilot-review.ymlworkflow. It requests the review asesphome-review-bot, which has a Copilot seat, on every non-draft PR when it is opened, pushed to, reopened or marked ready. Contributors there were not getting reviews before. The workflow and its notes: esphome/devices.esphome.io.github/workflows/request-copilot-review.yml(esphome/devices.esphome.io#1939, esphome/devices.esphome.io#1956, esphome/devices.esphome.io#1964). - esphome/esphome also has esphbot, which reviews on request. It and Copilot find different things, so running both adds coverage rather than duplicating it.
- I've given some of the more frequent contributors who are not members access to request esphbot reviews, so they are not stuck waiting for feedback on the main repo. Other non-members can only request one once esphbot has reviewed their PR at least once. Most of them haven't figured that out yet.
To discuss (esphome/esphome only)
The smaller repos keep their workflow; this issue is only about the main repo.
- Is a Copilot review on every contributor PR to esphome/esphome worth it?
- If yes: once per PR, or on every push?
- Dominant language
- No language data
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from esphome/backlog
-
Difficulty 1/5 Under an hour Newbie friendliness 25/100
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Difficulty 5/5 Over a week Newbie friendliness 15/100
-
Difficulty 4/5 3-5 days Newbie friendliness 15/100
-
Difficulty 5/5 Over a week Newbie friendliness 8/100
Similar issues
-
area: doc-engine area: infrastructure bug community-request
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
snapotter-hq/SnapOtter#4834 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
soroswap/token-list#125 ·
Maintainers usually reply within 1 day
-
enhancement roadmap: next
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
nekko-labs/nekko-agent#2998 ·
Maintainers usually reply within 1 day