Old watcher binaries are left in the plugin root after an update
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
Research direction
Start in lua/codediff/core/installer/watcher.lua, around lines 70-127, at the step that moves the versioned binary into the plugin root; note what path helpers the installer already uses to locate that root. After the move, add removal of any other codediff-watcher_* files there, taking care not to delete the binary just installed. Done means bumping the watcher version twice leaves exactly one watcher binary in the plugin root — verify by running the install path in Neovim with an old binary already present.
Written by the indexing model from the issue text.
Description
The watcher installer names each binary after its version (codediff-watcher_0.23.2) and moves the new one into the plugin root without removing the one it replaces, so every watcher version bump leaves the old binary behind.
Removing any other codediff-watcher_* after the move would fix it. Happy to send a PR if that'd help.
- Dominant language
- Lua
- Stars
- 1.6k
- Forks
- 104
- Avg merge
- 16d 23h
- Merged PRs (30d)
- 1
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from esmuellert/codediff.nvim
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
esmuellert/codediff.nvim#594 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
esmuellert/codediff.nvim#582 · 1 reaction ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
esmuellert/codediff.nvim#579 ·
-
Bug: explorer.focus_on_select = false ignored for added/untracked/deleted files in inline layoutOpenType/Bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
esmuellert/codediff.nvim#567 · 1 reaction ·
-
Type/Bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
esmuellert/codediff.nvim#565 · 1 comment ·
All issues in esmuellert/codediff.nvim
Similar issues
-
bug discord triage
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
AndyHazz/bookends.koplugin#134 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
coolsnowwolf/lede#14305 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100