Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

A cross-field `@@validate` rule is skipped on a partial `update()` — the ABSENT operand makes the comparison pass

Abierto
  • ¿Algo no está bien?
#2,833 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
65/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript
Área
backend

Línea de trabajo

The update validator is built at packages/orm/src/client/zod/factory.ts:2094-2097, where addCustomValidation is called without the present-field set; the comparison semantics are in packages/zod/src/utils.ts:429-437 (ABSENT sentinel) and :463-472 (evalBinary returns true on ABSENT). Read both sites and the create() path to see how present fields are supplied there, then choose between merging omitted row fields into the payload or rejecting an ABSENT comparison. Done when a model with @@validate(endDate > startDate) throws on update({ data: { endDate: earlier-than-startDate } }).

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Hi,

I run independent, pre-registered verification of AI-built software (Trenyx; the published engagements are at https://trenyx.io/audits.html) and did a static-only read of zenstackhq/zenstack at commit 3f1ed725, the plan hashed and anchored before reading. The access-control side held everywhere I pushed on it, and I want that on the record first: policies are injected at one query-executor choke point regardless of the ORM call shape (nested writes, createMany/updateMany/upsert, connect, polymorphic base/sub joins all reduce to the same enforcement), the RPC and REST adapters take the auth context only from the server-side getter, and every user-supplied key is gated by z.strictObject before a Kysely node exists (packages/orm/src/client/zod/factory.ts:500 makeWhereSchema, one of 63 strictObject sites). Nothing here is a security report. This is one correctness seam in validation.

The gap: a model-level @@validate rule that references two or more fields is silently skipped on update() when the payload omits one of them.

  • packages/orm/src/client/zod/factory.ts:2094-2097 builds the update validator by calling ZodUtils.addCustomValidation without the present-field set, so the evaluator has no way to know which referenced fields are absent from the payload versus absent from the row.
  • packages/zod/src/utils.ts:429-437 defines the ABSENT sentinel and :463-472 (evalBinary) returns true for any comparison in which an operand is ABSENT. A rule like endDate > startDate therefore passes whenever the update touches only one of the two fields.
  • The consequence is that a partial update is never checked against the row's true post-update state: an update({ data: { endDate } }) that makes endDate earlier than the stored startDate is accepted, while the same pair supplied together in create() is rejected. The validation attributes on single fields (@length, @email, @regex) are unaffected; this is specifically the cross-field case.

Suggested direction: on update(), either load the referenced fields that the payload omits and evaluate the rule on the merged value, or treat an ABSENT operand in a comparison as "cannot evaluate" and reject rather than pass, at least for rules that reference more than one field. One test would fence it: a model with @@validate(endDate > startDate), a row created with a valid pair, then update({ data: { endDate: <earlier than startDate> } }) expected to throw.

Happy to re-check whatever you ship. The pre-registration hash and the full record publish with the write-up, and if you ship a fix the write-up says so.

SK
Trenyx

Lenguaje dominante
TypeScript
Estrellas
2.9k
Forks
157
Merge medio
11 h 42 min
PR fusionados (30 d)
20

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de zenstackhq/zenstack

Todos los issues de zenstackhq/zenstack

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.