Improve detection for `noexec` for default extraction location

Abierto
#1,059 2 comentarios 1 reacción 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
java, sqlite
Área
database

Línea de trabajo

Read SQLiteJDBCLoader.extractAndLoadLibraryFile around the permission-setting calls cited in the issue, then trace how extraction failures become UnsatisfiedLinkError. Check how File.setExecutable and canExecute behave for the extracted library on Linux with a noexec temporary directory. Done when users receive actionable troubleshooting information for permission failures, including how to select an executable temporary directory.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement

Is your feature request related to a problem? Please describe.
When /tmp is mounted as noexec on Linux, sqlite-jdbc fails to load the native library with an error similar to the following:

java.lang.UnsatisfiedLinkError: /tmp/sqlite-...-libsqlitejdbc.so: /tmp/sqlite-...-libsqlitejdbc.so: failed to map segment from shared object

Users can fix this by not mounting /temp as noexec, or by specifying a custom java.io.tmpdir or org.sqlite.tmpdir system property value pointing to an (existing) directory with execution permission.
But just based on the UnsatisfiedLinkError above, it might not obvious to users what the cause is, or how to fix it.

See related issues:

  • #97 (some of the comments there)
  • #571

Describe the solution you'd like
sqlite-jdbc should try to detect noexec or other permission errors and report them properly before trying to load the native library and causing an UnsatisfiedLinkError,
or better (?) trigger an UnsatisfiedLinkError but attach additional information, such as whether permissions are correct.

Additionally it could suggest to set the java.io.tmpdir or org.sqlite.tmpdir system property value to an (existing) directory with execution permission.

Additional context
Maybe the checks in SQLiteJDBCLoader.extractAndLoadLibraryFile should be improved:
https://github.com/xerial/sqlite-jdbc/blob/2e336d9ecd40cf00e76ae71564a903e67afc163b/src/main/java/org/sqlite/SQLiteJDBCLoader.java#L207-L209

Issues with the current implementation:

  • It does not check the return value of the setReadable, ... calls
  • After the setExecutable call it should call file.canExecute()
    It seems for noexec file.setExecutable(true) succeeds but file.canExecute() is still false afterwards, so it could be detected like this.

However, I am not that familiar with Linux and the implementation details of java.io.File, so maybe there are cases where for example setReadable, ... fails but the library can still be loaded.
So maybe these checks should only be performed if an UnsatisfiedLinkError occurs, to provide additional troubleshooting information.

Potentially useful: https://github.com/netty/netty/pull/6707, but I am not sure if using PosixFilePermission is really needed or if using the java.io.File API suffices.

Lenguaje dominante
Java
Estrellas
3.3k
Forks
676
Merge medio
1 d 15 h
PR fusionados (30 d)
18

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de xerial/sqlite-jdbc

Todos los issues de xerial/sqlite-jdbc

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.