Allow HTTPS for WebSub hub topic operations from gateway-controller

Abierto
#4,266 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
47/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
go
Área
api, backend

Línea de trabajo

Start with gateway/gateway-controller/pkg/utils/api_deployment.go and trace how the router's WebSub hub listener ports and HTTPS settings are configured. Then read EventGatewayConfig.Validate() and the related configuration and tests to see how options are loaded and checked. Done means the scheme, port and CA settings are covered, HTTPS verifies the router certificate, and invalid or disabled HTTPS configurations are rejected.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Aspect/Other Type/Improvement
Please select the area the issue is related to

Gateway, Event Gateway

Please select the aspect the issue is related to

Aspect/Other (Anything else which does not match above categories)

Suggested Improvement

The gateway-controller registers and deregisters WebSub hub topics by sending a request to the router's internal WebSub hub listener. The URL's scheme is hard-coded to http:

// gateway/gateway-controller/pkg/utils/api_deployment.go
targetURL := fmt.Sprintf("http://%s:%d/websubhub/operations", webSubHubHost, webSubPort)

The router already exposes an HTTPS version of this internal listener on port 8446 (WEBSUB_HUB_INTERNAL_HTTPS_PORT) when HTTPS is enabled. Because the scheme is fixed, the controller can't use it. Deployments that want this traffic over TLS have no supported way to do that, for example when the controller and router run as separate containers or pods instead of sharing localhost.

Proposed Change
  1. Add a config option under router.event_gateway that selects the scheme, e.g. websub_hub_listener_scheme = "http" | "https". Default to http so existing deployments behave the same.
  2. When it's set to https:
    • Build the target URL with https:// and default the port to 8446 unless one is configured.
    • Use an HTTP client whose TLS settings trust the router's certificate. Allow a configurable CA bundle, and don't skip certificate verification.
  3. Validate the new option in EventGatewayConfig.Validate(). Reject unknown schemes, and reject https when the router's HTTPS listener isn't enabled.
Related Issues

No response

Lenguaje dominante
Go
Estrellas
85
Forks
137
Merge medio
1 d 12 h
PR fusionados (30 d)
247

Preparar el entorno

  • Sin Dockerfile ni archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de wso2/api-platform

Todos los issues de wso2/api-platform

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.