Hardening: refuse a JSON "dir" JWE without protected header and "aad", whose content can be an A*GCMKW encrypted key

Abierto
  • ¿Algo no está bien?
#760 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
php
Área
backend-api-design, security

Línea de trabajo

Read the decrypter and builder paths for JSON JWE handling, then trace how protected headers and aad determine content authentication data for dir. Check the existing tests for JSON serialization and decryption. Done means the decrypter rejects the described empty-AAD shape, the builder no longer emits it, and documentation recommends setting alg on keys shared across algorithms.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement
Version(s) affected

All released versions (3.4.x, 4.0.x, 4.1.x, 4.2.x), and the 4.3.x and 5.0.x branches.

Description

AES-GCM key wrapping (A128GCMKW, A192GCMKW, A256GCMKW) encrypts the CEK with AES-GCM under the key and an empty AAD. In the JSON serializations, a JWE may carry alg and enc outside the protected header. When it has neither a protected header nor an aad member, the AAD of its content is empty too, and with dir the content is then encrypted by the same computation as a GCM key wrap.

A decrypter that registers dir, an AGCMKW algorithm and the AGCM algorithm of the same size, and holds the key-wrapping key without an alg parameter, therefore accepts the encrypted key of an A*GCMKW token presented as the content of a dir JWE, and returns the CEK of that token as payload. Nothing is gained unless the application reveals decrypted payloads to the sender. If it does, the CEK opens the original token and allows new content under its encrypted key. Conversely, a JSON dir JWE issued without a protected header is a valid GCM key wrap of its plaintext.

This is a property of the JSON serializations rather than of this library alone: other implementations behave the same when they are given the raw key bytes (checked with panva/jose 6.2.2). Compact JWEs, and therefore JWTs, cannot take this shape.

Mitigations available today:

  • an alg parameter on every key (the key analyzer already reports keys without it);
  • an AlgorithmChecker that reads the protected header only;
  • not registering dir next to key wrapping algorithms in the same decrypter.
Possible Solution
  • The decrypter refuses a dir JWE whose content AAD is empty (no protected header and no aad), and the builder no longer produces one. This refuses a token shape the JSON serializations allow, so 4.3.0 with an upgrade note.
  • Documentation: recommend alg on the keys of a key set shared by several algorithms.

Related: #761 (key_ops does not tell content decryption from key unwrapping).

Additional Context

Found by the Anthropic OSS Scanner (ANT-2026-35BMRM17).

Lenguaje dominante
PHP
Estrellas
954
Forks
119
Merge medio
48 min
PR fusionados (30 d)
17

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de web-token/jwt-framework

Todos los issues de web-token/jwt-framework

Issues similares

Más issues de PHP

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.