SvelteKit deploy: the framework Worker packager resolves external packages with browser conditions, so `@sentry/sveltekit` fails to bundle
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 51/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- typescript, vite
- Área
- build-system
Línea de trabajo
Read packages/void/src/cli/wrapper.ts around bundleEntry and its WORKER_CONDITIONS, then compare the lib build in packages/void/src/cli/cf-build-output.ts. Add a fixture package with both browser and workerd exports and check that both packaging paths resolve the Worker entry to the workerd file. Done means the regression test passes and the Sentry and postgres repros package with Worker conditions.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Problem
A SvelteKit + Void app imports @sentry/sveltekit (11.7.0) in src/hooks.server.ts. vp build passes. void deploy then fails at the packaging step, before anything is uploaded:
● sveltekit framework deploy
● Found 1 migration
◇ Bundling worker...
■ Build failed with 1 error:
Error: [vite+]: Rolldown failed to resolve import "$app/stores" from
"…/node_modules/@sentry/sveltekit/build/esm/client/svelte4BrowserTracing.js".
This is most likely unintended because it can break your application at
runtime.
If you do want to externalize this module explicitly add it to
`build.rolldownOptions.external`
The void deploy --platform cloudflare packager has the same problem and gives the same error.
pg/MySQL SvelteKit apps hit it too after #413, with the same error.
The same cause can also fail without any error at build time. postgres (3.4.9) packages fine, but the packager picks its Node build. Node's net/crypto/stream become an empty stub, so the first query fails in workerd:
nodejs_als(the SvelteKit preset default):ReferenceError: Buffer is not definednodejs_als+nodejs_compat:TypeError: import___vite_browser_external.default.Socket is not a constructor
Repro
Start from playground/sveltekit (D1 + KV, @sveltejs/adapter-cloudflare 8, Kit 3).
- Add a dependency:
"@sentry/sveltekit": "11.7.0". - Add
src/hooks.server.ts:import * as Sentry from '@sentry/sveltekit'; import { sequence } from '@sveltejs/kit/hooks'; export const handle = sequence( Sentry.initCloudflareSentryHandle({ dsn: 'https://[email protected]/1', tracesSampleRate: 1 }), Sentry.sentryHandle(), ); export const handleError = Sentry.handleErrorWithSentry(); - Run:
For the native path, callvp build # passes void deploy --skip-build # fails at "Bundling worker..."prepareCfFrameworkBuildOutput(void deploy --platform cloudflareruns it as a preflight) on the same build. It fails with the same error.
Cause
Kit's server build leaves @sentry/sveltekit as a bare import (.svelte-kit/output/server/entries/hooks.server.js: import * as Sentry from "@sentry/sveltekit"). Void then bundles the adapter's _worker.js with a Vite lib build. That build has no ssr and no resolve.conditions, so Vite uses its client environment, with conditions ["module","browser","development|production"].
vp build (Kit + adapter-cloudflare)
└─ .svelte-kit/cloudflare/_worker.js ──> hooks.server.js ──> "@sentry/sveltekit" (external)
│
void deploy void deploy --platform cloudflare
runFrameworkDeploy prepareCfFrameworkBuildOutput
bundleEntry (wrapper.ts:520) prepareBundledBuildOutput (cf-build-output.ts:205)
└──── vite build({ build: { lib } }) → client env, "browser" condition ────┘
│
@sentry/sveltekit → build/esm/index.client.js → … → client/svelte4BrowserTracing.js
└─ import "$app/stores" ✗ (exists only inside Kit's build)
Code (on main, b58300ff8):
packages/void/src/cli/preset.ts:115-124: thesveltekitpreset setsbundle: true(:123). It is the only preset that does.packages/void/src/cli/deploy-managed-framework.ts:133-135: the hosted deploy callsbundleEntry(root, originalEntry).packages/void/src/cli/wrapper.ts:520-553:bundleEntryrunsbuild({ root, build: { lib: { entry, formats: ['es'] }, … } })and sets no conditions.packages/void/src/cli/deploy-cloudflare-build.ts:326-336: the native deploy runsprepareCfFrameworkBuildOutputfor everyworker-outputpreset (SvelteKit, Nuxt, Analog, Astro), as a preflight before remote changes. Only SvelteKit was tested.packages/void/src/cli/cf-build-output.ts:205-229:prepareBundledBuildOutputis the same kind of lib build (configFile: false,libat:225).packages/void/src/plugin-framework.ts:280-321: for pg/MySQL, thevoid:sveltekit-worker-buildplugin moves onlyvoid,drizzle-orm, the driver and packages that importvoidinto Kit's workerd build. "Other dependencies stay external" (:287), so they still reach the browser-condition packager.
@sentry/[email protected] package.json → exports["."]:
{
"types": "./build/types/index.types.d.ts",
"workerd": { "import": "./build/esm/index.workerd.js", "require": "./build/cjs/index.workerd.js" },
"worker": { "import": "./build/esm/index.worker.js", "require": "./build/cjs/index.worker.js" },
"browser": { "import": "./build/esm/index.client.js", "require": "./build/cjs/index.client.js" },
"node": { "import": "./build/esm/index.server.js", "require": "./build/cjs/index.server.js" },
"default": { "import": "./build/esm/index.server.js", "require": "./build/cjs/index.server.js" }
}
With the client conditions, only browser matches, so the import resolves to index.client.js. That file is browser code: it pulls in Kit's $app/* modules and does not export initCloudflareSentryHandle or sentryHandle.
[email protected] exports["."] is { "workerd": "./cf/src/index.js", "import": "./src/index.js", … }. The client conditions skip workerd and match import, which is the Node build.
Check: the same bundleEntry options plus only resolve.conditions: ['workerd','worker','browser','module','import','default']:
@sentry/sveltekitresolves toindex.workerd.js. The build passes, and the Worker returns 200 for/in Miniflare withnodejs_als.postgresresolves tocf/src/index.js. The query reaches a real socket connect.
Suggested fix
Give both lib builds Worker resolve conditions. wrapper.ts:315-316 already defines WORKER_CONDITIONS and uses it for the SQL driver bundle (wrapper.ts:353-357). Use it in bundleEntry and prepareBundledBuildOutput (resolve: { conditions: WORKER_CONDITIONS }). prepareCfStaticBuildOutput (cf-build-output.ts:256) shares prepareBundledBuildOutput, so it gets the same change. Add a regression test with a fixture package that has both browser and workerd exports, and check that the packaged Worker uses the workerd file.
🤖 Generated with Claude Code
- Lenguaje dominante
- TypeScript
- Estrellas
- 402
- Forks
- 32
- Merge medio
- 11 h 52 min
- PR fusionados (30 d)
- 88
Preparar el entorno
Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de voidzero-dev/void
-
bug
Dificultad 1/5 1-3 horas Aptitud para principiantes 78/100
voidzero-dev/void#428 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
voidzero-dev/void#511 ·
Los mantenedores suelen responder en 1 día
-
Platform email: outbound-only custom domain for an apex whose MX belongs to another providerAbierto
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
voidzero-dev/void#510 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 58/100
voidzero-dev/void#509 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 55/100
voidzero-dev/void#507 ·
Los mantenedores suelen responder en 1 día
Todos los issues de voidzero-dev/void
Issues similares
-
Edit: Tele Posadas HDAbiertocheck:passed streams:edit
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
Los mantenedores suelen responder en 1 día
-
area:mcp bug has repro platform:vscode regression
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
anthropics/claude-code#103970 ·
Los mantenedores suelen responder en 1 día
-
skillopt: success-reflect prompt omits the edit schema, so every success-only edit is droppedAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 1 día
-
Workspace secrets/constants containing "$" are corrupted when resolved in data source optionsAbiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
Los mantenedores suelen responder en 1 día
-
sdk-typescript: unquoted COPY globs in shell form are silently dropped from the image build contextAbiertobug javascript
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 1 día