world-postgres: startup recovery re-enqueues runs without a recorded namespace under the World's own prefix, not the registered flow handler's

Abierto
#5,442 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
50/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
postgresql, typescript
Área
databases

Línea de trabajo

Start at the start() call in packages/world-postgres/src/index.ts, where the TODO points to this issue, and read reenqueueActiveRuns in @workflow/world to see how the fallback namespace is chosen. Find where the flow handler's in-process registration and its namespace are available before start(). Done when runs without a recorded namespace are re-enqueued under that handler's prefix, runs with a recorded namespace are unchanged, and the registration warning is still shown.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Summary

On start(), the Postgres World re-enqueues every active run it owns (reenqueueActiveRuns from @workflow/world, called from packages/world-postgres/src/index.ts). A run goes back to the queue namespace it recorded when it was created; a run that recorded none goes to the World's own namespace (the namespace option, or WORKFLOW_QUEUE_NAMESPACE in the World's process).

Since #5315 the World delivers the Workflow SDK's messages in process, to the flow handler the app registered. That handler is registered under the prefix the flow route was built with (WORKFLOW_QUEUE_NAMESPACE at build time). When that prefix differs from the World's own, the World warns once at registration and still delivers what the SDK publishes, but the runs it recovers at startup without a recorded namespace go to its own prefix, which no handler in the process takes: the runner claims the job and fails the delivery.

Intended fix

Recover such runs under the registered flow handler's prefix rather than the World's namespace option: when a flow handler (one carrying the in-process entry) is registered before start(), pass its namespace as the fallback to reenqueueActiveRuns. Runs that recorded a namespace are unaffected.

Current state

The limitation is noted in the Postgres World docs (Programmatic configuration) and in the registration warning, and a TODO at the start() call in packages/world-postgres/src/index.ts points here.

Related: #2978 covers the wider question of isolating applications that share one database; this issue is only about the fallback namespace of recovery inside one application.

Lenguaje dominante
TypeScript
Estrellas
2.5k
Forks
401
Merge medio
1 d 21 h
PR fusionados (30 d)
201

Preparar el entorno

  • Sin Dockerfile ni archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de vercel/workflow

Todos los issues de vercel/workflow

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.