Fullscreen table and Mermaid views don't move, keep or restore keyboard focus

Abierto
  • ¿Algo no está bien?
#731 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
62/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
react, typescript
Área
accessibility, frontend

Línea de trabajo

Start in the fullscreen overlay for tables and Mermaid diagrams, which renders role="dialog" and aria-modal="true", and in the "View fullscreen" button that opens it. Reproduce on the playground and check document.activeElement after opening and closing. Done when focus moves to the close button on open, Tab stays inside the dialog or the page behind it is inert, and focus returns to the opening button on close.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Bug Description

The fullscreen overlay for tables and Mermaid diagrams renders role="dialog" and aria-modal="true", but it never moves focus into the dialog:

  • After opening, focus stays on the "View fullscreen" button, which is now hidden behind the overlay.
  • Tab moves through page content behind the overlay.
  • Closing the overlay drops focus to <body>, so keyboard and screen reader users lose their place.
Steps to Reproduce
  1. Open https://streamdown.ai/playground (the default content includes a table and Mermaid diagrams).
  2. Click "View fullscreen" on the table.
  3. Check document.activeElement. It is still the "View fullscreen" button behind the overlay.
  4. Press Tab. Focus moves to a "Download file" button of a code block behind the overlay.
  5. Click the close (X) button. document.activeElement is now <body>.

The same happens with "View fullscreen" on a Mermaid diagram.

Expected Behavior

Follow the WAI-ARIA modal dialog pattern:

  • When the dialog opens, move focus into it (for example to the close button).
  • Keep Tab inside the dialog, or make the content behind it inert.
  • When it closes, return focus to the "View fullscreen" button that opened it.
Actual Behavior

Focus never enters the dialog, Tab reaches hidden content, and focus is lost on close.

Code Sample
import { Streamdown } from "streamdown";
import { mermaid } from "@streamdown/mermaid";

const markdown = `| Feature | Status |
| --- | --- |
| Tables | Supported |

\`\`\`mermaid
flowchart LR
  A --> B
\`\`\``;

export function Example() {
  return <Streamdown plugins={{ mermaid }}>{markdown}</Streamdown>;
}
Streamdown Version

2.7.1 (also on streamdown.ai/playground)

React Version

19.3.1

Browser(s)

Chrome (desktop)

Operating System

macOS

Additional Context

Neither fullscreen component has any focus handling: there is no focus() call, focus trap or inert in either. A fix could:

  • remember document.activeElement when opening;
  • focus the close button after the dialog mounts;
  • set inert on the rest of the page while open;
  • return focus to the remembered element on close.

Related: #506 added role="dialog" and aria-modal to the Mermaid overlay, but focus handling is still missing.

Lenguaje dominante
TypeScript
Estrellas
5.8k
Forks
334
Merge medio
2 d 4 h
PR fusionados (30 d)
33

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de vercel/streamdown

Todos los issues de vercel/streamdown

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.