test : add unit tests for generate_finding_key in finding_intelligence

Abierto
  • ¿Algo no está bien?
#2,235 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

  • #2240 de @tmdeveloper007 — cerrado sin fusionar

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
35/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
fastapi, python
Área
security, testing

Línea de trabajo

Read backend/secuscan/finding_intelligence.py to inspect generate_finding_key and the existing tests for its component functions. Then create testing/backend/unit/test_finding_intelligence_key.py and cover determinism, differing plugin_id, target, and owner_id values, missing fields, and the specified group:<16-character-hex-digest> format. The issue notes that a linked pull request exists and says the work is being handled by tmdeveloper007.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Summary of What Needs to be Done:
The backend/secuscan/finding_intelligence.py module exposes a generate_finding_key function that produces a stable deduplication key for a finding. The function is responsible for consistent identification of the same vulnerability across different scan tasks. It is currently not directly unit tested — only its component functions (_issue_signature, _guess_asset_ref, _stable_id) have isolated tests.

Changes that Need to be Made:
Create testing/backend/unit/test_finding_intelligence_key.py with tests for generate_finding_key:

  • Returns a string starting with "group:"
  • Same inputs produce the same output (deterministic)
  • Different plugin_id values produce different outputs
  • Different target values produce different outputs
  • Different owner_id values produce different outputs
  • Missing/None fields in the finding dict are handled gracefully
  • The key format matches the pattern "group:<16-char-hex-digest>"

Impact that it would Provide:

  • Directly tests the finding deduplication key generation used for deduplication across tasks
  • Documents the expected stable key format for maintainers
  • Ensures the function is deterministic and handles edge-case inputs
  • Complements existing tests for _issue_signature and _stable_id

Note: This task is being handled by tmdeveloper007 — please assign to that account when picking it up.

Lenguaje dominante
Python
Estrellas
36
Forks
234
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de utksh1/SecuScan

Todos los issues de utksh1/SecuScan

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.