[Bug]: Desktop: Dialog scrim doesn't dim artwork or backdrops

Abierto
#126 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
50/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
rust
Área
desktop

Línea de trabajo

Start at the scrim in desktop/app/src/ui/overlay.rs:22, then find where the poster, card and title-backdrop primitives are drawn and how their draw order relates to the scrim layer. Reproduce with cargo run --locked -- --scene discover --snapshot /tmp/a.png versus --scene add, and the same for title versus releases, comparing pixels. Done means every element behind an open dialog dims while the dialog panel still covers correctly.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a review session of the desktop app (#80) with @PhrolovaMoe. It was found in headless renders of the debug build's fixture scenes (--snapshot), not on a live server.

Version

0.40.0 (feat/desktop, 017a837b)

Area

Other (desktop app)

What happened?

Behind a dialog, text and panels are dimmed by the scrim (desktop/app/src/ui/overlay.rs:22), but posters, cards and the title backdrop aren't: their pixels are identical with and without the dialog open. They're drawn by custom shader primitives, which end up on top of the scrim. The dialog panel itself still covers them correctly.

Steps to reproduce

From desktop/, with a debug build: compare cargo run --locked -- --scene discover --snapshot /tmp/a.png with --scene add --snapshot /tmp/b.png: the poster at the left is just as bright in both. Same for --scene title vs --scene releases (the backdrop).

Expected behavior

Everything behind a dialog dims the same way.

Suggested fix

Draw the scrim (and the dialog) in a layer above the primitives, or have the artwork/backdrop primitives take the dimming into account while an overlay is open.

Lenguaje dominante
TypeScript
Estrellas
4
Forks
1
Merge medio
4 h 49 min
PR fusionados (30 d)
5

Preparar el entorno

  • Incluye un Dockerfile o un archivo de Docker Compose
  • Sin plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de tinystream-dev/tinystream

Todos los issues de tinystream-dev/tinystream

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.