No force setting a cookie in localStorage when theme mode stays at default

Abierto
  • ¿Algo no está bien?
#1,512 4 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
react, tailwindcss, typescript
Área
frontend

Línea de trabajo

Reproduce el problema en un proyecto de Gatsby usando los componentes Flowbite y Flowbite-react, y luego busca la cookie flowbite-theme-mode y su gestión en localStorage. Confirma el comportamiento cuando no hay ningún modo de tema configurado; se considera terminado cuando el modo claro predeterminado funciona sin forzar esa cookie ni ese valor de almacenamiento.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

  • [x ] I have searched the Issues to see if this bug has already been reported
  • [ x] I have tested the latest version

Steps to reproduce

  1. Create a gatsbyjs project
  2. Install Flowbite and Flowbite-react
  3. Implement component without setting a theme
  4. Develop with 'Gatsby develop'
  5. Take a look into local storage in browser

Current behavior

The 'flowbite-theme-mode' cookie is ALWAYS being set even if no theme mode being used.

Expected behavior

Having control over what cookie being set or at least fix a default value somewhere else preventing a cookie being set, when no theme mode is being used. I expect a default value written in the codes core not in a cookie.

Context

I tried to remove the cookie by code. Since I am using multiple templates, I tried removing it with onClientEntry and onInitialClientRender which will only succeed once. As soon as the site being reloaded, the cookie is back.

There seems to be no option to control this cookie. Searching the code also results in nothing. I could not find anything to control this cookie. I do use a custom theme but with no theme mode. It should be light by default, but it should definitely not being read from the local storage but being set internally. It does not make much sense to force write a default value into a cookie when this value will never ever change.

No dark mode, just default light mode.

If you dont respect GDPR because it is annoying we can team up: I dont like the rules either!
But reading default values from a cookie which is written by default does not make a lot of sense. Store the default values in the core, not in a cookie.

NOTE: I know some people are allergic on this specific issue. You can detach this from the GDPR topic and focus on NOT setting a cookie when there is no theme mode.

Lenguaje dominante
TypeScript
Estrellas
2.2k
Forks
504
Merge medio
19 h 16 min
PR fusionados (30 d)
2

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de themesberg/flowbite-react

Todos los issues de themesberg/flowbite-react

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.