Bug: LogMessageWaitStrategy: a container that exits before its message raises without its logs, and __enter__ then removes the container

Abierto Apto para principiantes
#1,138 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@granzer69 ya está trabajando en esto.

Desde el 22/10/2026.

  • #1139 de @granzer69 — abierto

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
76/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
docker, python
Área
devtools, testing

Línea de trabajo

Lee core/wait_strategies.py, especialmente LogMessageWaitStrategy.wait_until_ready y su ruta de timeout. Después, comprueba en core/container.py cómo DockerContainer.start gestiona las excepciones. Reproduce el problema con el comando de MongoDB proporcionado y compara el error de proceso terminado con el error de timeout. El trabajo estará completo cuando el mensaje de RuntimeError de la ruta de proceso terminado incluya el fragmento disponible de stdout y stderr.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Version: testcontainers 4.15.0 (Python). The same code is on main as read on 2026-10-20.

What happens. A container that exits before it logs the message a LogMessageWaitStrategy waits for raises:

RuntimeError: Container exited (status: exited, exit code: 1) before emitting logs containing 'waiting for connections'. Container error: . Hint: Check container logs and ensure the application is configured to start correctly. The application may be crashing or exiting early.
The hint says to check the container's logs, but there is no way to read them afterwards:

LogMessageWaitStrategy.wait_until_ready (core/wait_strategies.py) has the logs in hand when it notices the exit. It has just called container.get_logs() to search them. But the RuntimeError it raises carries only the status, the exit code and State.Error, which is the daemon's own error field and is empty when the process exits on its own. Its timeout path does include "Recent stdout" and "Recent stderr", while its exited path does not.
DockerContainer.start (core/container.py) attaches the logs as a note only on except TimeoutError, so the RuntimeError above passes through without them.
DockerContainer.enter catches any exception from start(), calls exit, which stops and removes the container with remove(force=True, v=True), and re-raises. By the time the error reaches the caller, the container and its logs are gone.
So a container that dies at start under with DockerContainer(...) as c: leaves nothing to diagnose it with. This is the case the hint is written for.

How we met it. mongod 8.3.13 refuses some host kernels at startup (SERVER-121912). It logs one fatal line and exits 1, and GitHub's ubuntu-24.04 runner image 20261018 carries such a kernel. Our CI showed only the message above, about 3,000 times, once per test. The cause became visible only after we started our containers without the context manager, read get_logs() in our own except and removed the container ourselves.

To reproduce:

from testcontainers.core.container import DockerContainer
from testcontainers.core.wait_strategies import LogMessageWaitStrategy

container = DockerContainer("mongo:8.3.13").with_command("--refusedAtStart")
container.waiting_for(LogMessageWaitStrategy("waiting for connections"))
with container:
pass
mongod refuses the unknown option, logs why and exits. The error names neither the option nor mongod's line.

Suggested fix. On the exited path, include the tail of the stdout and stderr the strategy already read, as the timeout path does. Because the message carries the log, a caller that only has str(error) gets it too: pytest-xdist workers, for example, receive only the string, so a note would be lost on the way.

Lenguaje dominante
Python
Estrellas
2.3k
Forks
395
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de testcontainers/testcontainers-python

Todos los issues de testcontainers/testcontainers-python

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.