Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

bug: soilid data rank number is being improperly assigned due to a missing dataframe sorting step

Abierto
  • ¿Algo no está bien?
#256 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 9 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
52/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
python
Área
data

Línea de trabajo

Start by locating the rank_soils function and inspect how its dataframe is ordered before rank_data is assigned. Reproduce the reported point at 44.63165, -123.19684, then verify that the component with the highest score_data receives rank_data 1 and that the returned soilRank ordering is correct.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Description

Current 'rank_soils' function is missing a dataframe sorting step required to correctly assign a number ranking for the 'rank_data' field returned from the api.

Steps To Reproduce

create point in app and populate user data with values that are similar to a soil with a low location rank. Because of the incorrect ordering of the dataframe, the component where 'rank_data' = 1 will not be the component with the highest 'score_data'.

Expected behavior

Willamette has the highest "score_data":0.942 and is correctly assigned the top "rank_data":"1"

Corrected rank_soils return with texture class entered for 112-155cm depth and correct sorting 
# Sort dataframe to correctly assign Rank_Data
D_final = D_final.sort_values(by=["soilID_rank_data", "Score_Data"], ascending=[False, False])

{
   "metadata":{
      "location":"us",
      "model":"v2"
   },
   "soilRank":[
      {
         "name":"Woodburn",
         "component":"Woodburn",
         "componentID":25270809,
         "score_data_loc":0.913,
         "rank_data_loc":"1",
         "score_data":0.906,
         "rank_data":"2",
         "score_loc":0.92,
         "rank_loc":1,
         "componentData":"Data Complete"
      },
      {
         "name":"Willamette",
         "component":"Willamette",
         "componentID":25270986,
         "score_data_loc":0.765,
         "rank_data_loc":"2",
         "score_data":0.942,
         "rank_data":"1",
         "score_loc":0.588,
         "rank_loc":2,
         "componentData":"Data Complete"
      },
      {
         "name":"Amity",
         "component":"Amity",
         "componentID":25270996,
         "score_data_loc":0.571,
         "rank_data_loc":"3",
         "score_data":0.906,
         "rank_data":"3",
         "score_loc":0.237,
         "rank_loc":3,
         "componentData":"Data Complete"
      },
      {
         "name":"Dayton",
         "component":"Dayton",
         "componentID":25270995,
         "score_data_loc":0.407,
         "rank_data_loc":"4",
         "score_data":0.794,
         "rank_data":"4",
         "score_loc":0.02,
         "rank_loc":4,
         "componentData":"Data Complete"
      }
   ]
}

Actual behavior

Current results for the test point: 44.63165, -123.19684

Willamette has highest "score_data" but is ranked 2 for "rank_data" Current rank_soils return with texture class entered for 112-155cm depth with missing sorting step 
{
   "metadata":{
      "location":"us",
      "model":"v2"
   },
   "soilRank":[
      {
         "name":"Woodburn",
         "component":"Woodburn",
         "componentID":25270809,
         "score_data_loc":0.913,
         "rank_data_loc":"1",
         "score_data":0.906,
         "rank_data":"1",
         "score_loc":0.92,
         "rank_loc":1,
         "componentData":"Data Complete"
      },
      {
         "name":"Willamette",
         "component":"Willamette",
         "componentID":25270986,
         "score_data_loc":0.765,
         "rank_data_loc":"2",
         "score_data":0.942,
         "rank_data":"2",
         "score_loc":0.588,
         "rank_loc":2,
         "componentData":"Data Complete"
      },
      {
         "name":"Amity",
         "component":"Amity",
         "componentID":25270996,
         "score_data_loc":0.571,
         "rank_data_loc":"3",
         "score_data":0.906,
         "rank_data":"3",
         "score_loc":0.237,
         "rank_loc":3,
         "componentData":"Data Complete"
      },
      {
         "name":"Dayton",
         "component":"Dayton",
         "componentID":25270995,
         "score_data_loc":0.407,
         "rank_data_loc":"4",
         "score_data":0.794,
         "rank_data":"4",
         "score_loc":0.02,
         "rank_loc":4,
         "componentData":"Data Complete"
      }
   ]
}
Lenguaje dominante
Python
Estrellas
2
Forks
3
Merge medio
8 d 4 h
PR fusionados (30 d)
10

Preparar el entorno

  • Incluye un Dockerfile o un archivo de Docker Compose
  • Sin plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de techmatters/soil-id-algorithm

Todos los issues de techmatters/soil-id-algorithm

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.