Make `run-task` and `docker-image` hashes optional in cache names
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
Línea de trabajo
Start at src/taskgraph/transforms/task.py around line 519 and trace how run-task and docker-image hashes enter cache names. Resolve the default behavior, interpolation format, cache-type risk, and backward-compatibility approach described in the issue. Done means projects and individual caches can choose whether to include either hash without losing cache correctness.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Currently Taskgraph adds both the hash of run-task and the docker-image tasks to cache names (if those things are being used):
https://github.com/taskcluster/taskgraph/blob/e5565787fc8d546cbb906c6efe6702420e6891f0/src/taskgraph/transforms/task.py#L519
This ensures correctness, it almost guarantees that we won't get errors due to different versions of tools being used across the same set of files. However, it comes at the cost of more cache misses!
For example, in Gecko we typically have a ton of tasks coming in for any given docker-image. Furthermore, pools tend to only run tasks with certain images, so this feature makes a lot of sense.
On the other hand, mozilla-vpn-client has only a single pool that runs a wide array of tasks with docker-images. Further, pushes come in infrequently so workers aren't very long lived. This means we almost never have cache hits.
Another point is the type of cache. Checkout caches tend to be more susceptible (especially with Mercurial) to this, but something like a dotfile cache might not be (maybe?). The point is different kinds of caches have different levels of risk for this.
I propose that instead of automatically adding the run-task and docker-image hashes to all cache names, we use them as values that can be interpolated into the cache name. I.e, a cache name could be checkouts-{run_task}-{docker_image} and these values would be included in the hash name. Or it could just be checkouts and then they wouldn't. This allows individual projects, and even individual caches within a project, to set up cache names however is best for that context.
There's definitely an open question around whether one or both of these hashes should be included by default. Also how hard we should try to preserve backwards compatibility.
- Lenguaje dominante
- Python
- Estrellas
- 26
- Forks
- 55
- Merge medio
- 2 d 6 min
- PR fusionados (30 d)
- 15
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de taskcluster/taskgraph
-
Dependency Dashboard Abierto
Dificultad 5/5 Más de una semana Aptitud para principiantes 20/100
taskcluster/taskgraph#952 ·
-
Dificultad 4/5 3-5 días Aptitud para principiantes 35/100
taskcluster/taskgraph#915 ·
-
feature
Dificultad 3/5 1-2 días Aptitud para principiantes 35/100
taskcluster/taskgraph#911 · 1 comentario ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 45/100
taskcluster/taskgraph#882 ·
-
Further optimize Git clones Abierto
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
taskcluster/taskgraph#865 · 1 comentario ·
Todos los issues de taskcluster/taskgraph
Issues similares
-
essnmx good first issue
Dificultad 1/5 Menos de una hora Aptitud para principiantes 95/100
-
[Feature] 奇物选择添加优先级 Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
syfoud/Simulated_Scepter#174 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
Giskard-AI/giskard-oss#2840 · 1 comentario ·
-
A claim comment carrying the issue number is silently declined while the workflow reports success Abiertoarea: repo bug perceived difficulty: 2
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
yeti-platform/yeti#1380 ·