Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

A handler installed with `SA_RESTART` does not restart the interrupted syscall

Abierto
  • ¿Algo no está bien?
#418 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 3 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
c, linux
Área
operating-systems

Línea de trabajo

Start with syscall_restart_arm in src/syscall/proc.h, which today handles only execve on the thread group leader, and read the comment explaining why a signal delivered before resume cancels it. The fix depends on #384, since the handler frame carries the wire value in X8 rather than the syscall number. Build the reproducer from the issue, which should match Linux for FUTEX_WAIT and a pipe read (rc=0 and rc=1 respectively) instead of EINTR.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

Linux restarts a syscall that a signal interrupted when the handler was installed with SA_RESTART and the syscall is one of the restartable ones in signal(7): read on a pipe or socket, futex FUTEX_WAIT without a timeout, wait4, accept and so on. elfuse returns EINTR to the guest instead. Measured for the two below; the others are untested.

The dispatcher has a restart path (syscall_restart_arm in src/syscall/proc.h), but it serves only an execve handed to the thread group leader, and a signal delivered before the guest resumes cancels it. The comment there gives the reason: the frame the handler returns through carries the wire value in X8 and not the syscall number, so a rewound PC would re-execute a different syscall. That is #384, which this depends on.

Reproducer: a SIGUSR1 handler installed with SA_RESTART, one thread parked in each wait, pthread_kill(SIGUSR1) at it, then the wait released (a FUTEX_WAKE after storing 1, a one-byte write).

#include <errno.h>
#include <linux/futex.h>
#include <pthread.h>
#include <signal.h>
#include <stdint.h>
#include <stdio.h>
#include <string.h>
#include <sys/syscall.h>
#include <unistd.h>

static uint32_t word;
static int pfd[2];
static volatile int handled;

static void on(int s)
{
    (void) s;
    handled++;
}

static void *w_futex(void *a)
{
    (void) a;
    long r = syscall(SYS_futex, &word, FUTEX_WAIT, 0, NULL, NULL, 0);
    printf("futex FUTEX_WAIT: rc=%ld errno=%d\n", r, r < 0 ? errno : 0);
    return NULL;
}

static void *w_read(void *a)
{
    (void) a;
    char c;
    long r = read(pfd[0], &c, 1);
    printf("read on a pipe:   rc=%ld errno=%d\n", r, r < 0 ? errno : 0);
    return NULL;
}

static void rel_futex(void)
{
    word = 1;
    syscall(SYS_futex, &word, FUTEX_WAKE, 1, NULL, NULL, 0);
}

static void rel_read(void)
{
    write(pfd[1], "x", 1);
}

static void run(void *(*fn)(void *), void (*release)(void))
{
    pthread_t t;
    pthread_create(&t, NULL, fn, NULL);
    usleep(200000);
    pthread_kill(t, SIGUSR1);
    usleep(300000);
    release();
    pthread_join(t, NULL);
}

int main(void)
{
    struct sigaction sa;
    memset(&sa, 0, sizeof sa);
    sa.sa_handler = on;
    sa.sa_flags = SA_RESTART;
    sigaction(SIGUSR1, &sa, NULL);
    pipe(pfd);
    run(w_futex, rel_futex);
    run(w_read, rel_read);
    printf("handler ran %d times\n", handled);
    return 0;
}
wait elfuse Linux 6.12 under qemu
futex(FUTEX_WAIT), no timeout rc=-1 errno=4 rc=0
read on an empty pipe rc=-1 errno=4 rc=1

The handler runs both times on both.

The waits signal(7) lists as never restarted (nanosleep, select, poll, epoll_wait among them) are out of scope: EINTR is right for those.

Lenguaje dominante
C
Estrellas
275
Forks
29
Merge medio
2 d 8 h
PR fusionados (30 d)
17

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de sysprog21/elfuse

Todos los issues de sysprog21/elfuse

Issues similares

Más issues de C

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.