Ask for Feedback: Make `JSObject` / `JSFunction` calls be `throws`

Abierto

#272 abierto el 25/11/2024 2 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad: 5/5
Tiempo estimado: Más de una semana
Aptitud para principiantes: 25/100

Tipo de issue: Nueva funcionalidad
Claridad: Necesita aclaración
Estado de actividad: Estancado
Stack tecnológico: javascript, swift, wasm
Área: api

Línea de trabajo

El issue menciona JSObject y JSFunction como las APIs afectadas, pero no proporciona ningún archivo ni punto de entrada de prueba. Revisa sus implementaciones de llamadas y el comportamiento existente de .throws/.throwing; después, mide el compromiso de rendimiento y define pruebas para llamadas que lanzan excepciones y que no las lanzan antes de decidir el cambio incompatible de la API.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Every dynamic JS function calls can throw an exception, but the current JSObject and JSFunction are non-throws by default.
They can be throws by .throws or .throwing but it's still opt-in.

For example, if an exception is thrown during a JS function call but the call site in Swift side is not throws, the control unwinding wasm call frames without executing function epilogues even if there is do { } catch {} clause in Swift. And also in that case, defer blocks won't be called.

This behavior is quite tricky and unwinding wasm call frames without executing function epilogues can lead to memory and resource leak.

I'm going to introduce an API breaking change to make JSObject / JSFunction calls be throws in the next next release to improve the situation.

This change has a performance tradeoff as throws variants are typically a little bit slower than non-throwing variants. We should measure the amount of the penalty but it shouldn't be a big deal. We can make non throwing calls as an opt-in feature so that those who want best performance can satisfy their needs.

// Before
let foo = JSObject.global.document.getElementById!("foo")
let foo = try JSObject.global.document.throwing.getElementById!("foo")

// After
let foo = try JSObject.global.document.getElementById!("foo")
let foo = JSObject.global.document.nonthrowing.getElementById!("foo")

Let me know here if you have a strong objection 🙏 Thanks.