Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

AIX: sudo (use_pty) can hang forever in tcsetattr(TCSADRAIN) at command exit, blocking all further sudo on that tty

Cerrado
  • ¿Algo no está bien?
#581 4 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
c
Área
operating-systems

Línea de trabajo

The hang occurs in sudo_term_restore() called from pty_cleanup() during exec_pty(). Locate the terminal restore code (likely src/pty.c) and review the tcsetattr call with TCSADRAIN. Use the attached sudo_pty_hang_kit.zip to reproduce on AIX and verify the process exits. Done means sudo returns promptly without blocking when the pty master is not read.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Summary

On AIX 7.3, sudo can hang indefinitely at command exit, in sudo_term_restore() -> tcsetattr(TCSADRAIN).

This happens when output is still queued on the user's tty and nobody reads the pty master (for example sshd stops reading after the client connection stalls or is lost). While it hangs, sudo holds its tty lock, so every further sudo by that user on that tty queues behind it.

I do not think sudo is doing anything wrong by POSIX: TCSADRAIN is documented to wait for queued output. But on AIX that wait never ends, and cannot be interrupted, once the master side stops draining. Linux returns immediately in the same situation (see below). I am reporting this because a more defensive terminal restore on exit (non-blocking, or with a time limit) would avoid the hang on AIX, and an operating system fix may take a long time. I have also raised the AIX behaviour with the OS vendor (IBM).

Environment
  • AIX 7.3: multiple TLs and SPs but our reproducer is 7300-04-02
  • sudo 1.9.17p2-1 (AIX Toolbox rpm), use_pty (default), sudo started from an ssh session
  • Linux comparison: kernel 7.x
Observed stack of the hung process
ioctl(.., 0x5403, ..)          (process sleeping in the kernel, not killable with kill -9 while the `pty` master is open)
tcsetattr
tcsetattr_nobg
sudo_term_restore_v1
pty_cleanup.constprop.0
exec_pty
sudo_execute
run_command
main

A second sudo by the same user waits in:

lockf64
sudo_lock_region_v1
sudo_lock_file_v1
sudo_term_copy_v1
exec_pty
Reproducer (attached: sudo_pty_hang_kit.zip)

sudo_pty_hang_kit.zip, README inside

Deterministic, no ssh, no root, about 15 seconds. As a regular user with passwordless sudo:

perl sudo_pty_hang.pl -n 3000 -w 12 -k

It opens a pty (/dev/ptc), starts sudo sh -c '<print 3000 bytes>' with the pty slave as controlling tty, and never
reads the master.

Result: sudo never exits. With -r (master is read) sudo exits after one second.
./run_pty_hang.sh hold leaves the hung sudo frozen for inspection (procstack, truss), release ends it.

Not sudo specific

tcdrain_sim.pl (no sudo, no sshd): fill the output queue of a pty slave, do not read the master, call tcsetattr():

mode AIX 7.3 Linux 7.x
TCSANOW returns immediately returns immediately
TCSADRAIN blocks (still blocked after 8 s, no end) returns immediately
TCSAFLUSH blocks (still blocked after 8 s, no end) returns immediately

A C program with the same logic behaves the same on AIX.

Suggestion

At command exit, sudo could avoid an unbounded wait on AIX, for example by:

  • restoring the terminal with TCSANOW instead (TCSAFLUSH is no alternative, it blocks on AIX as well),
  • or draining with a timeout, giving up (with a log message) if the tty does not drain,
  • or releasing the tty lock before the potentially blocking restore, so one stuck session does not block all later sudo calls.

I understand that restoring with TCSANOW may lose queued output in some cases, so I am not sure what the best trade-off is. I am happy to test patches on AIX 7.3.

Workaround

Defaults !use_pty avoids the hang (at the cost of use_pty features such as I/O logging).

Lenguaje dominante
C
Estrellas
1.7k
Forks
306
Merge medio
1 d 8 h
PR fusionados (30 d)
24

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de sudo-project/sudo

Todos los issues de sudo-project/sudo

Issues similares

Más issues de C

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.