Cleared legacy TOML settings reappear after restart

Abierto
  • ¿Algo no está bien?
#182 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
65/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript
Área
backend, cli

Línea de trabajo

Look at the TOML write path in the settings manager, likely in a file like src/settings/manager.ts. The issue mentions a merge behavior that resurrects cleared nested tables. Start by running the core settings tests to reproduce the bug. Examine how setStepSettings handles undefined and how the TOML serialization merges with the original document. The fix should ensure cleared settings are not written back to disk.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area/config bug
What happened?

Clearing a nested legacy setting from config.toml updates the in-memory settings, but the old value is written back to disk and returns after reload/restart.

For example, [feedback] enabled = false becomes cleared in the current manager after setStepSettings({ feedbackEnabled: undefined }), but a new manager reads feedbackEnabled: false again. The TOML write path merges the original document back over the cleared state, which resurrects the removed nested table.

I reproduced this on clean main @ adcf37b in the core settings tests, without external extensions. I have a local fix and regression test ready and would like to submit a PR if this direction looks good.

Steps to reproduce
  1. Put this in config.toml: 
    [feedback]
enabled = false
  2. Start/load Step settings and confirm feedbackEnabled is false.
  3. Call setStepSettings({ feedbackEnabled: undefined }).
  4. Confirm the current manager now reports the setting as absent.
  5. Reload the settings or restart Step.
  6. feedbackEnabled: false appears again.
Expected behavior

Cleared legacy TOML settings should stay removed after reload/restart, while unrelated TOML fields and mcp_servers remain intact.

Version

main @ adcf37b / @step-harness/coding-agent 0.84.4

Lenguaje dominante
TypeScript
Estrellas
1k
Forks
71
Merge medio
13 h 14 min
PR fusionados (30 d)
66

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de stepfun-ai/Step-Code

Todos los issues de stepfun-ai/Step-Code

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.