Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Support `ClientHttpMessageConvertersCustomizer` in `FeignHttpMessageConverters` for Spring Boot 4.0 Alignment

Abierto
  • ¿Algo no está bien?
#1,293 6 comentarios 1 reacción 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
65/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Tranquilo
Stack tecnológico
java, spring, spring-boot
Área
api, backend

Línea de trabajo

Empieza en FeignHttpMessageConverters.java, especialmente en el constructor y en initConvertersIfRequired(), e inspecciona en qué se diferencia ClientHttpMessageConvertersCustomizer del HttpMessageConverterCustomizer existente de Feign. Sigue el flujo y el orden de ClientBuilder antes de decidir dónde deben ubicarse los client customizers. Se considera terminado cuando los client customizers de Spring Boot 4 afectan a los conversores de Feign sin romper el comportamiento existente de los conversores ni de los Feign-customizers.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

waiting-for-triage

Is your feature request related to a problem? Please describe.
With the architectural changes in Spring Boot 4.0 (as detailed in spring-projects/spring-boot#48310), the configuration of HTTP Message Converters has shifted from collecting all HttpMessageConverter beans from the context to using dedicated customizers (ClientHttpMessageConvertersCustomizer for clients and ServerHttpMessageConvertersCustomizer for servers).

Currently, FeignHttpMessageConverters in Spring Cloud OpenFeign constructs the converter list by collecting raw HttpMessageConverter<?> beans from the ObjectProvider and applying its own Feign-specific org.springframework.cloud.openfeign.support.HttpMessageConverterCustomizer.

This creates an inconsistency in the ecosystem. If I configure a converter using the standard Spring Boot 4.0 ClientHttpMessageConvertersCustomizer (intended for RestClient and RestTemplate), OpenFeign ignores it. I am forced to either:

  1. Define the converter as a raw @Bean (which Spring Boot 4.0 discourages for auto-configuration context pollution).
  2. Duplicate the configuration using the Feign-specific HttpMessageConverterCustomizer.

Describe the solution you'd like
FeignHttpMessageConverters should detect and apply ClientHttpMessageConvertersCustomizer beans from the application context. This would allow a single point of configuration for all HTTP clients (Feign, RestClient, and RestTemplate) in a Spring Boot 4.0 application.

In FeignHttpMessageConverters.java, specifically within the initConvertersIfRequired() method, the logic builds an HttpMessageConverters instance using HttpMessageConverters.ClientBuilder. Since ClientHttpMessageConvertersCustomizer is designed to customize HttpMessageConverters, it seems natural to apply these customizers there.

Proposed logic change conceptually:

public class FeignHttpMessageConverters {
    
    // Inject ClientHttpMessageConvertersCustomizer provider
    private final ObjectProvider<ClientHttpMessageConvertersCustomizer> clientCustomizers;

    // ... constructor ...

    private void initConvertersIfRequired() {
       if (this.converters == null) {
          // ... existing builder logic ...
          
          HttpMessageConverters hmc = builder.build();
          
          // PROPOSED CHANGE: Apply Spring Boot Client Customizers
          if (this.clientCustomizers != null) {
              this.clientCustomizers.orderedStream().forEach(customizer -> customizer.customize(hmc));
          }

          // Continue with existing logic
          hmc.forEach(converter -> converters.add(converter));
          customizers.forEach(customizer -> customizer.accept(this.converters));
       }
    }
}

Describe alternatives you've considered

  • Current Workaround: Defining a separate @Bean for org.springframework.cloud.openfeign.support.HttpMessageConverterCustomizer that duplicates the logic present in my ClientHttpMessageConvertersCustomizer.
  • Global Bean: Defining the converter as a global @Bean marked with @Primary. However, as mentioned in the linked Spring Boot issue, relying on collecting beans from the context is being revisited and might not be the preferred way forward for separate client/server configurations.

Additional context
References:

  • Spring Boot Issue: Revisit HttpMessageConverters auto-configuration #48310
  • Current implementation of FeignHttpMessageConverters relies on: 
    public FeignHttpMessageConverters(ObjectProvider<HttpMessageConverter<?>> messageConverters,
      ObjectProvider<HttpMessageConverterCustomizer> customizers) {
   this.messageConverters = messageConverters;
   this.customizers = customizers;
}
    It misses the ClientHttpMessageConvertersCustomizer which is now the standard for client-side configuration in Boot 4.
Lenguaje dominante
Java
Estrellas
1.3k
Forks
835
Merge medio
19 h 49 min
PR fusionados (30 d)
24

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de spring-cloud/spring-cloud-openfeign

Todos los issues de spring-cloud/spring-cloud-openfeign

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.