`step ca renew` doesn't handle quoted arguments in `--exec` parameter

Abierto
#1,538 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
go
Área
cli

Línea de trabajo

Start by locating the step ca renew implementation that parses and executes the --exec parameter; the issue does not name a file or test. Check how quoted arguments are currently split and look for relevant command-execution tests. Done means quoted arguments, including the curl -H parameters described here, are passed as intended, or the limitation is documented.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement needs triage

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

The implementation blindly splits at spaces regardless of whether they're quoted, so the command is executed differently than e.g., if it were passed as an argument to sh -c.

Why is this needed?

I ran into this issue when trying to use curl to execute a Caddy configuration reload; in this case, it breaks the -H parameters.

I'm calling it an enhancement but this ticket could also be a bug. There's an easy workaround (put the command in a script file) so documenting the limitation would also be an acceptable fix.

Lenguaje dominante
Go
Estrellas
4.3k
Forks
320
Merge medio
2 d 3 h
PR fusionados (30 d)
11

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de smallstep/cli

Todos los issues de smallstep/cli

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.