Cache translation from channel and user name to ID (translation prone to failure)
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
Línea de trabajo
Start with lib/slack/web/api/mixins/channels.id.rb and the background in #270. Compare the three proposed approaches, including conversations.list pagination and the current README guidance, then establish which behavior should be supported. Done means the chosen channel-name translation policy is implemented and the README accurately documents it.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
When a channel name is given for a channel parameter, rather than a channel ID, we are using channels.list to look up the ID of the channel and then using the ID in the request instead of the name.
However, channels.list is a legacy method and is no longer guaranteed to return every channel. This leads to a channel_not_found error if you pass a channel name for a channel that is not supported by channels.list.
A couple suggested solutions:
- Update
channels_idto useconversations.listinstead ofchannels.list. The tricky thing about this is thatconversations.listonly works with pagination, so it's not a simple drop-in replacement. It also means that if you do something likechat_postMessage(channel: 'general', text: 'foo')then for a team with many channels you might end up making hundreds of paginated calls toconversations.listbefore actually hittingchat.postMessage, which is not ideal. If we use this solution I think we should change the readme to discourage this approach and encourage using channel IDs directly. - Remove the translation completely, which would be a breaking change (but not the worst breaking change, since it's already basically broken). Since using
conversations.listis not ideal for making the translation (see above) we could remove support for this altogether, forcing people to confront the issue directly. - Leave it as it is, and update the readme to note that it does not always work and discourage its use.
See #270 for more background.
- Lenguaje dominante
- Ruby
- Estrellas
- 1.3k
- Forks
- 222
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de slack-ruby/slack-ruby-client
-
new feature question
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
slack-ruby/slack-ruby-client#586 · 3 comentarios ·
-
Make gli an optional dependency (only bin/slack needs it)Posiblemente ocupada @corsonknowles la tomó hoy. Abierto
Dificultad 3/5 1-2 días Aptitud para principiantes 72/100
slack-ruby/slack-ruby-client#601 · 1 comentario ·
-
bug?
Dificultad 2/5 1-3 horas Aptitud para principiantes 45/100
slack-ruby/slack-ruby-client#579 · 3 comentarios ·
-
Error details aren't passed throughPosiblemente ocupada Un pull request vinculado a esta issue está abierto o ya se fusionó. Abiertonew feature web api
Dificultad 3/5 1-2 días Aptitud para principiantes 42/100
slack-ruby/slack-ruby-client#482 · 5 comentarios ·
-
new feature
Dificultad 4/5 3-5 días Aptitud para principiantes 35/100
slack-ruby/slack-ruby-client#414 · 15 comentarios ·
Todos los issues de slack-ruby/slack-ruby-client
Issues similares
-
Allow customizing the page titleAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
rails/mission_control-jobs#347 ·
-
PROJECT: ILR/DRS
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
thewca/worldcubeassociation.org#15914 ·
Los mantenedores suelen responder en 1 día
-
good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
benbalter/site-inspector#127 ·
Los mantenedores suelen responder en 1 día
-
good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
benbalter/jekyll-remote-theme#168 ·
Los mantenedores suelen responder en 1 día
-
good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
benbalter/jekyll-titles-from-headings#109 ·
Los mantenedores suelen responder en 1 día